Repository navigation
Merge train train-261117m: 1 reviewed PRs - #8234
Merged
Merged
Conversation
… as fixtures Copies of corpus pull request 1426 (tests/al-language/pages/parts/ListHostFactBoxNewLine.al) and of the reporter's repro: a List page with one CardPart FactBox linked to the key, around the new line. The test that runs them comes with the fix. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
On a top-level List page opened with OpenEdit, with OnAfterGetRecord only and one CardPart FactBox linked to the one-field key, BC runs the part's OnAfterGetCurrRecord on the blank record at the open of an empty view, at the key's SetValue on the new line and at Next onto it; keeps the part on the row before after New() until the key's SetValue; and runs no OnAfterGetRecord of the host on Next back to the row the line saved. The runner ran none of that. The new module pages/list_factbox_new_line.rs admits only the probe's page shapes and call sequences, through the assumption list-factbox-new-line (corpus pull request 1426); every other shape keeps main's path, and after the New() that kept the part, calls other than a read of the part, the key's SetValue and Close are refused. test_page_op shrank: its cap goes from 276 to 271. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…probe shows none (#8188) Review: the host's reads and property calls (Value, Caption, Editable, ...) after that New() were refused although their answers do not depend on the part; they now run as on main. The key's SetValue took the measured blank-record read for any text that fit the field, a duplicate key included; the candidate key is now converted to the field and must be not blank and the key of no stored row, and the measured call sequence is required. Any other key SetValue lets the part read the new line as main does at New() and goes on as on main. Rust tests compare a host read, a Caption, a duplicate key (also lower case), a blank key and a key after a Caption with main's answers; the refused calls now run in codeunits of their own so a refusal does not hide later tests. The assumption text says what the code checks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Corpus pull requests 1426 and 1425 are merged (not pinned yet); the citations already name their lines. docs/codemap.md: keep main's new go_to_key_read_up.rs entry and this branch's pinned_shape.rs entry. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…-line steps Review of #8190 found two facts the entry condition did not check. The probe's field controls carry only ApplicationArea and its table fields no property, yet Editable = false on the host's key control still took the new path, and with a TableRelation on the key the part ran OnAfterGetCurrRecord before the SetValue failed and the steps stayed in HeldRead. factbox_line_pages now also requires field controls of the host and the part with no property but ApplicationArea, a repeater with none, a table with no property but DataClassification and table fields with none (ListHostFactBoxNewLine.al:14, :18-19, :39-42, :74). A SetValue that raises an error sets factbox_line back to Off (factbox_line_after_set_value), so the later calls take main's path. The Rust tests compare each new neighbor with main's log. The assumption text and docs/probes-needed.md follow the narrower shape. docs/codemap.md and the assumption entry go back to LF line endings. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge train of 1 reviewed pull request(s).
Fixes #8188
https://claude.ai/code/session_01PQNbkrP3bBGQSQ7Hnd9Pps