byoc: add Azure args to byoc provision command - #468
Draft
aiven-marko-rauhamaa wants to merge 2 commits into
Draft
byoc: add Azure args to byoc provision command#468aiven-marko-rauhamaa wants to merge 2 commits into
aiven-marko-rauhamaa wants to merge 2 commits into
Conversation
Add cloud identity options to byoc provision: - AWS: --aws-iam-role-arn - Google: --google-privilege-bearing-service-account-id - Azure: --azure-subscription-id, --azure-client-id, --azure-client-secret, --azure-tenant-id The three groups are mutually exclusive; all four Azure args must be provided together. Co-Authored-By: Claude <noreply@anthropic.com> [IP-1059]
aiven-marko-rauhamaa
force-pushed
the
aiven-marko-rauhamaa-IP-1059
branch
from
August 1, 2026 11:17
b759e9a to
bc44fa7
Compare
aiven-marko-rauhamaa
changed the title
Address new ruff rule violations surfaced by the 0.15.x upgrade: collapse nested ifs, add ClassVar layout annotations, modernize collection literals, and ignore PLR0917 for legacy positional APIs. Co-Authored-By: Composer <noreply@cursor.com>
aiven-marko-rauhamaa
marked this pull request as ready for review
August 1, 2026 21:30
aiven-marko-rauhamaa
marked this pull request as draft
August 3, 2026 09:21
heikju
reviewed
Aug 3, 2026
| "--google-privilege-bearing-service-account-id", | ||
| help="The privilege-bearing service account that Aiven is authorized to impersonate to operate the cloud (Google)", | ||
| ) | ||
| @arg("--azure-subscription-id", help="The Azure subscription ID where the BYOC infrastructure is deployed (Azure)") |
Contributor
There was a problem hiding this comment.
The commit message also lists pre-existing CLI options for other cloud providers as ones being added, which is a bit inconsistent with what's actually here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cloud identity options to byoc provision:
--azure-client-secret, --azure-tenant-id
The three groups are mutually exclusive; all four Azure args must be provided together.
Co-Authored-By: Claude noreply@anthropic.com
IP-1059