fix: drop the self-assignment at the top of ContextInstanceMixin.get_current - #1895
Open
darkdi wants to merge 2 commits into
Open
fix: drop the self-assignment at the top of ContextInstanceMixin.get_current#1895darkdi wants to merge 2 commits into
darkdi wants to merge 2 commits into
Conversation
❌ Changelog is required!You need to add a brief description of the changes to the Changes file should be named like The content of the file should be a brief description of the changes in Possible categories are: |
Author
|
Fragment is in as CHANGES/1895.misc.rst, but changes-required looks like it cannot go green on any fork PR at the moment: actions/checkout refuses to check out fork code under pull_request_target unless the step sets allow-unsafe-pr-checkout: true, so the job dies before towncrier runs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_currentopens withcls.__context_instance = cls.__context_instance.__init_subclass__already sets that attribute on every subclass, so the read and the write hit the same entry in the class dict and the line is a no-op. It reads as if it were priming something, which is what sent me looking.