fix: [UI:settings edit] correctly allow setting passivessh config - #435
Open
Wachizungu wants to merge 1 commit into
Open
Wachizungu wants to merge 1 commit into
Wachizungu wants to merge 1 commit into
Conversation
Fixes a copy paste error. passive ssh settings edit functions were pointing to passivedns routes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a copy paste error.
passive ssh settings edit functions were pointing to passivedns routes.
Current issue (didn't confirm this manually but fairly confident):
Clicking "enable/disable passive SSH" toggles passive DNS instead; saving passive SSH credentials overwrites the passive DNS credentials, and passive SSH can never be enabled/edited from the UI.
NOTE: I didn't verify functionality manually after, so please double check.