You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously, the logout test failed because an asynchronous command-list event polluted its snapshot.
Updated legacy type imports and fixtures for new schema fields. The logout snapshot now isolates the actual logout response, avoiding unrelated events.
Congrats on the 0.147.0 bump! A few things caught my eye:
CommandAction.ts now uses LegacyAppPathString — a type that was apparently born retired. Shipping legacy code on day one is an impressive velocity metric, but could we get a note on what makes it "legacy" and whether there's a non-legacy path being planned? Or is this name inherited from upstream codex and we're just stuck with it? 🏛️
Also, the whole isPinned → ThreadSection migration is a real glow-up, but every single test update swapped isPinned: false for section: null. That means the test suite is now exclusively covering the "sections don't exist" scenario. Could we get at least one test where section is an actual ThreadSection with an id and name, and sectionEnteredAt is a real timestamp? Right now the feature is covered in tests the same way my gym membership covers my fitness. 🏋️
Lastly, ToolRequestUserInputParams deprecated autoResolutionMs in favor of isBlocking — tests now set isBlocking: true, but does autoResolutionMs still appear anywhere in the codebase? A quick grep for existing usages would be reassuring before the deprecated field is left to haunt future maintainers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Previously, the logout test failed because an asynchronous command-list event polluted its snapshot.
Updated legacy type imports and fixtures for new schema fields. The logout snapshot now isolates the actual logout response, avoiding unrelated events.