docs(codex): warn that mutating CLI commands reformat config.toml#2537
docs(codex): warn that mutating CLI commands reformat config.toml#2537latreon wants to merge 1 commit into
Conversation
.codex/config.toml kept showing up as locally modified: running a mutating Codex CLI subcommand (e.g. `codex mcp add chrome-devtools ...`) rewrites the file in place, stripping every comment and reflowing the TOML formatting in the process — with no code change behind it, just tool-driven drift on whoever's machine ran the command. Added a caution note directing personal MCP servers and local overrides to the user's own ~/.codex/config.toml instead of this project-local template. Also added chrome-devtools as a new commented-out optional entry alongside the existing supabase/firecrawl/fal-ai/cloudflare examples, since it's a genuinely useful MCP server worth documenting the same way as its siblings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🔇 Additional comments (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Codex configuration template now warns that MCP-related CLI commands can rewrite the file and directs personal overrides to ChangesCodex configuration template
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
daltino
left a comment
There was a problem hiding this comment.
This PR adds a helpful warning to the config.toml file, explaining that mutating Codex CLI commands rewrite the file and strip comments/formatting. The note also provides practical guidance to use ~/.codex/config.toml for personal MCP servers or overrides, which is a thoughtful addition. The change is clear and aligns with the repo's focus on improving user documentation.
Summary
.codex/config.tomlkept showing up as locally modified with no intentional edit behind it: running a mutating Codex CLI subcommand (e.g.codex mcp add chrome-devtools ...) rewrites the file in place, stripping every comment and reflowing the TOML formatting — pure tool-driven drift on whoever's machine ran the command, not a real change.~/.codex/config.tomlinstead of editing this project-local template with mutating CLI commands.chrome-devtoolsas a new commented-out optional entry alongside the existingsupabase/firecrawl/fal-ai/cloudflareexamples — it's a genuinely useful MCP server worth documenting the same way as its siblings.Diff is a comment-only addition — 9 lines, no functional config changes.
Test plan
node tests/codex-config.test.js— 5/5 pass@iarna/tomlto confirm it's still valid TOML andchrome-devtoolsstays inert (commented out, not a parsed table)node tests/run-all.js— 3110/3110 pass