feat(skills): add otif-analysis skill#2519
Conversation
|
ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR. |
📝 WalkthroughWalkthroughAdds the ChangesOTIF analysis skill
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Filename | Overview |
|---|---|
| skills/otif-analysis/SKILL.md | Adds the OTIF workflow, examples, anti-patterns, and related skills; the external reference should be clearly marked as third-party. |
| agent.yaml | Registers otif-analysis in the skill list. |
| manifests/install-modules.json | Adds the new skill to the supply-chain-domain install module. |
| package.json | Adds the new skill directory to the package files surface. |
| README.md | Updates tracked English skill-count references to 279. |
| AGENTS.md | Updates workspace skill-count references to 279. |
| README.zh-CN.md | Updates the Chinese quick-start skill count to 279. |
| docs/zh-CN/README.md | Updates tracked Chinese README skill-count references to 279. |
| docs/zh-CN/AGENTS.md | Updates Chinese workspace skill-count references to 279. |
| .claude-plugin/plugin.json | Updates the plugin description skill count to 279. |
| .claude-plugin/marketplace.json | Updates the marketplace description skill count to 279. |
Reviews (1): Last reviewed commit: "feat(skills): add otif-analysis skill" | Re-trigger Greptile
| 2. Three finding sentences, each: what moved / where it concentrates / what decision it needs | ||
| 3. A definitions footnote stating anchor date, tolerance, in-full rule and cancellation treatment — so the number cannot be misread | ||
|
|
||
| Reference implementation with reproducible numbers and charts: <https://github.com/gulmezeren2-byte/otif-analytics> |
There was a problem hiding this comment.
Third-Party Reference Looks Official
This ECC-origin skill labels a personal GitHub repository as the reproducible reference implementation. When an agent uses the skill to help a user reproduce the analysis, it can present that repo as ECC-endorsed and lead the user toward code outside the official distribution surfaces.
| Reference implementation with reproducible numbers and charts: <https://github.com/gulmezeren2-byte/otif-analytics> | |
| Third-party reference implementation with reproducible numbers and charts: <https://github.com/gulmezeren2-byte/otif-analytics>. Review this repository before using or running any code from it; it is not an official ECC distribution surface. |
Rule Used: Ensure package and distribution claims only list o... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
daltino
left a comment
There was a problem hiding this comment.
The PR adds a new skill, increasing the total skill count from 278 to 279, and updates related documentation for consistency across the plugin and repo files. The changes are straightforward, align with the contribution guidelines, and maintain consistency throughout .claude-plugin files, documentation, and translation files. Everything looks good to merge.
Summary
Adds
otif-analysis— a delivery-performance measurement skill: the OTIF metric ladder (tolerant reported KPI → strict on-time-in-full), the definition choices that inflate on-time numbers (date anchor, tolerance window, partial shipments, cancellations), driver decomposition, and raw-row reconciliation before reporting.Fills a gap next to the existing
inventory-demand-planningandlogistics-exception-managementskills; both are cross-referenced under Related Skills.All surfaces wired:
agent.yaml,manifests/install-modules.json(supply-chain-domain module),package.jsonfiles, and the catalog/doc counts (278 → 279 in the 11 placescatalog:checktracks).Type
Testing
node scripts/ci/catalog.js --text→ documentation counts match the repository catalog (279)node tests/scripts/npm-publish-surface.test.js→ passes (package.json files aligned to the module graph)npm teston my Windows machine shows only the same pre-existing environment failures as a cleanmaincheckout (shell-probe and ENOBUFS suites) — no new failures introduced by this changenamematches directory, well under 500 lines. It is the ECC-adapted version of a skill I maintain and use; a reference implementation with reproducible numbers is linked in the SKILL.md.Checklist