Skip to content

feat(skills): add otif-analysis skill#2519

Open
gulmezeren2-byte wants to merge 1 commit into
affaan-m:mainfrom
gulmezeren2-byte:feat/otif-analysis-skill
Open

feat(skills): add otif-analysis skill#2519
gulmezeren2-byte wants to merge 1 commit into
affaan-m:mainfrom
gulmezeren2-byte:feat/otif-analysis-skill

Conversation

@gulmezeren2-byte

@gulmezeren2-byte gulmezeren2-byte commented Jul 14, 2026

Copy link
Copy Markdown

Summary

Adds otif-analysis — a delivery-performance measurement skill: the OTIF metric ladder (tolerant reported KPI → strict on-time-in-full), the definition choices that inflate on-time numbers (date anchor, tolerance window, partial shipments, cancellations), driver decomposition, and raw-row reconciliation before reporting.

Fills a gap next to the existing inventory-demand-planning and logistics-exception-management skills; both are cross-referenced under Related Skills.

All surfaces wired: agent.yaml, manifests/install-modules.json (supply-chain-domain module), package.json files, and the catalog/doc counts (278 → 279 in the 11 places catalog:check tracks).

Type

  • Skill
  • Agent
  • Hook
  • Command

Testing

  • node scripts/ci/catalog.js --text → documentation counts match the repository catalog (279)
  • node tests/scripts/npm-publish-surface.test.js → passes (package.json files aligned to the module graph)
  • Full npm test on my Windows machine shows only the same pre-existing environment failures as a clean main checkout (shell-probe and ENOBUFS suites) — no new failures introduced by this change
  • Lockfiles untouched
  • Skill follows the checklist: "When to Activate", copy-pasteable example, Anti-Patterns, folded description scalar, name matches directory, well under 500 lines. It is the ECC-adapted version of a skill I maintain and use; a reference implementation with reproducible numbers is linked in the SKILL.md.

Checklist

  • Follows format guidelines
  • Tested with Claude Code
  • No sensitive info (API keys, paths)
  • Clear descriptions

@ecc-tools

ecc-tools Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds the otif-analysis skill, registers it for installation and packaging, and synchronizes English and Chinese plugin documentation to report 279 skills.

Changes

OTIF analysis skill

Layer / File(s) Summary
OTIF analysis workflow
skills/otif-analysis/SKILL.md
Defines OTIF data requirements, metric-ladder calculations, gap analysis, anti-patterns, output structure, and related skills.
Skill registration and packaging
agent.yaml, manifests/install-modules.json, package.json
Registers otif-analysis in the skill list, installation paths, and published package files.
Catalog and documentation counts
.claude-plugin/*, AGENTS.md, README*, docs/zh-CN/*
Updates plugin metadata and documentation references from 278 to 279 skills.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • affaan-m/ECC#2118: Updates the same skill-count metadata and documentation fields.
  • affaan-m/ECC#2202: Adds a skill while synchronizing catalog counts and packaging.
  • affaan-m/ECC#2230: Updates shared skill-count strings across manifests and documentation.

Suggested reviewers: affaan-m

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely states the main change: adding the otif-analysis skill.
Description check ✅ Passed The description is directly related to the change and accurately summarizes the new skill, integrations, and validation.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a new OTIF analysis skill and wires it into the catalog. The main changes are:

  • New skills/otif-analysis/SKILL.md workflow content.
  • Registration in agent.yaml, package.json, and manifests/install-modules.json.
  • Skill-count updates across English and Chinese docs plus plugin metadata.

Confidence Score: 4/5

The new skill is mostly wired correctly, but the external reference needs a clearer third-party boundary before merging.

  • Skill registration and catalog-count updates line up with the new directory.
  • The new skill points to a personal GitHub repository from an ECC-origin instruction surface.
  • A short disclaimer or official-surface replacement would make the provenance clear.

skills/otif-analysis/SKILL.md

Security Review

The new skill includes an agent-facing link to a non-ECC GitHub repository without a clear third-party warning, which can create supply-chain trust confusion.

Important Files Changed

Filename Overview
skills/otif-analysis/SKILL.md Adds the OTIF workflow, examples, anti-patterns, and related skills; the external reference should be clearly marked as third-party.
agent.yaml Registers otif-analysis in the skill list.
manifests/install-modules.json Adds the new skill to the supply-chain-domain install module.
package.json Adds the new skill directory to the package files surface.
README.md Updates tracked English skill-count references to 279.
AGENTS.md Updates workspace skill-count references to 279.
README.zh-CN.md Updates the Chinese quick-start skill count to 279.
docs/zh-CN/README.md Updates tracked Chinese README skill-count references to 279.
docs/zh-CN/AGENTS.md Updates Chinese workspace skill-count references to 279.
.claude-plugin/plugin.json Updates the plugin description skill count to 279.
.claude-plugin/marketplace.json Updates the marketplace description skill count to 279.

Reviews (1): Last reviewed commit: "feat(skills): add otif-analysis skill" | Re-trigger Greptile

2. Three finding sentences, each: what moved / where it concentrates / what decision it needs
3. A definitions footnote stating anchor date, tolerance, in-full rule and cancellation treatment — so the number cannot be misread

Reference implementation with reproducible numbers and charts: <https://github.com/gulmezeren2-byte/otif-analytics>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 security Third-Party Reference Looks Official

This ECC-origin skill labels a personal GitHub repository as the reproducible reference implementation. When an agent uses the skill to help a user reproduce the analysis, it can present that repo as ECC-endorsed and lead the user toward code outside the official distribution surfaces.

Suggested change
Reference implementation with reproducible numbers and charts: <https://github.com/gulmezeren2-byte/otif-analytics>
Third-party reference implementation with reproducible numbers and charts: <https://github.com/gulmezeren2-byte/otif-analytics>. Review this repository before using or running any code from it; it is not an official ECC distribution surface.

Rule Used: Ensure package and distribution claims only list o... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@daltino daltino left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds a new skill, increasing the total skill count from 278 to 279, and updates related documentation for consistency across the plugin and repo files. The changes are straightforward, align with the contribution guidelines, and maintain consistency throughout .claude-plugin files, documentation, and translation files. Everything looks good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants