Repository navigation
test: move fixed test ports below the ephemeral range - #97
Merged
Merged
Conversation
Swap GitHub-hosted runner labels for Blacksmith (2 vCPU x64, 4 vCPU for the slowest build jobs). actions/cache and setup-* caches move to Blacksmith's colocated cache with no code change.
The MCP tests bound fixed ports 45551-45568, inside Linux's ephemeral range (32768-60999). An outbound socket can hold one of them, the server then falls back to the next free port, and the port assertion fails. That flaked once on main after the Blacksmith switch (45564 taken). Ports 27551-27568 are outside the range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP tests bind fixed ports 45551-45568, which sit inside Linux's ephemeral port range (32768-60999). Any outbound connection can grab one, then the server falls back to the next free port and the port check fails. It flaked once on main after the Blacksmith move (run 38920157631: 45564 was taken, server took 45565; the rerun passed).
Moves the test ports to 27551-27568, outside that range. Local
npm testpasses.Need help on this PR? Tag
@codesmith-botwith what you need.