Repository navigation
feat: option to include subfolder prefixes in bucket.list() - #1168
Merged
Merged
Conversation
Comment on lines
+49
to
+52
| /** | ||
| * whether to include subfolder prefixes | ||
| */ | ||
| subPrefixes: boolean; |
Contributor
There was a problem hiding this comment.
Would you also settle for prefixes only? They are sub folders, but not sub prefixes 😉
dominique-pfister
approved these changes
Nov 25, 2025
|
This PR will trigger a minor release when merged. |
Contributor
|
🎉 This PR is included in version @adobe/helix-shared-storage-v1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tripodsan
reviewed
Nov 25, 2025
tripodsan
left a comment
tripodsan
left a comment
Contributor
There was a problem hiding this comment.
ok for me. but I think includePrefixes would be a better option name
| async list(prefix, opts = false) { | ||
| const { | ||
| shallow = false, maxItems = Number.POSITIVE_INFINITY, | ||
| shallow = false, maxItems = Number.POSITIVE_INFINITY, prefixes = false, |
Contributor
There was a problem hiding this comment.
maybe use includePrefixes ?
Contributor
Author
There was a problem hiding this comment.
naming is hard 😉
let me change it to be includePrefixes before anyone is actually using it.
Contributor
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To include subfolder prefixes in the result, use: