Skip to content

ci: Make python warnings failures in pytest #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
benjaminhuth wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −5
Draft

ci: Make python warnings failures in pytest #5682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
736dfbb
try it
benjaminhuth Jul 14, 2026
61afe65
fix(tests): close hash file handle in conftest to avoid ResourceWarning
benjaminhuth Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions Python/Examples/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,12 @@ def __init__(

def _parse_hash_file(file: Path) -> Dict[str, str]:
res = {}
for line in file.open():
if line.strip() == "" or line.strip().startswith("#"):
continue
key, h = line.strip().split(":", 1)
res[key.strip()] = h.strip()
with file.open() as f:
for line in f:
if line.strip() == "" or line.strip().startswith("#"):
continue
key, h = line.strip().split(":", 1)
res[key.strip()] = h.strip()
return res


Expand Down
2 changes: 2 additions & 0 deletions pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,5 @@ markers =
edm4hep
odd
hepmc3
filterwarnings =
error
Loading