Skip to content

fix(embeddings): retry install with --ignore-scripts on native build failure #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
efenocchi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(embeddings): retry install with --ignore-scripts on native build failure #249

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3b52b8
fix(embeddings): retry install with --ignore-scripts on native build …
efenocchi Jun 9, 2026
61a0b13
fix(publish): include embeddings/ dir in npm files
efenocchi Jun 9, 2026
1bfe897
test(embeddings): cover _installWithFallback retry paths + apply Code…
efenocchi Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions src/cli/embeddings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,26 @@ function ensureSharedDeps(): void {
private: true,
dependencies: { [TRANSFORMERS_PKG]: TRANSFORMERS_RANGE },
});
execFileSync("npm", ["install", "--omit=dev", "--no-package-lock", "--no-audit", "--no-fund"], {
cwd: SHARED_DIR,
stdio: "inherit",
});
const npmArgs = ["install", "--omit=dev", "--no-package-lock", "--no-audit", "--no-fund"];
try {
execFileSync("npm", npmArgs, { cwd: SHARED_DIR, stdio: "inherit" });
} catch {
// sharp has no prebuilt binary for some Node versions (e.g. Node v26 on macOS)
// and requires node-gyp to build from source. Retry without scripts — sharp is
// only used for image processing; text embeddings are unaffected.
warn(` Embeddings native build failed; retrying without install scripts`);
warn(` Embeddings (sharp image support unavailable — text embeddings unaffected)`);
execFileSync("npm", [...npmArgs, "--ignore-scripts"], { cwd: SHARED_DIR, stdio: "inherit" });
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
// onnxruntime-node's postinstall downloads its prebuilt binary; re-run it
// explicitly since --ignore-scripts skipped it.
const onnxScript = join(SHARED_NODE_MODULES, "onnxruntime-node", "script", "install.js");
if (existsSync(onnxScript)) {
execFileSync("node", [onnxScript], {
cwd: join(SHARED_NODE_MODULES, "onnxruntime-node"),
stdio: "inherit",
});
}
}
} else {
log(` Embeddings shared deps already present at ${SHARED_DIR}`);
}
Expand Down
Loading