fix(model): add DisableReportPushConfigInProject for project deletion#3343
Merged
Conversation
Add a storage helper to disable enabled report push configs before project deletion, so delete flow can stop push rules without blocking. Fixes actiontech/dms-ee#440
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Seechi-Yolo
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Problem
Deleting a DMS project fails when SQLE report push configs are enabled (default workflow push is enabled on project creation). The delete pre-check blocks deletion instead of stopping push rules automatically.
Solution
Add
DisableReportPushConfigInProjectstorage helper to disable enabled report push configs before project deletion proceeds.Test plan
make EDITION=ce docker_installpassesFixes actiontech/dms-ee#440
Description
新增 DisableReportPushConfigInProject 方法
禁用启用状态的 report push config
修复项目删除时的阻塞问题
Diagram Walkthrough
File Walkthrough
report_push_config.go
新增禁用ReportPushConfig函数sqle/model/report_push_config.go