Compat SPE / SPEX - Add ace_overheating_barrelMass to small arms

[jpspider1]

When merged this pull request will:

• Apply ace_overheating_barrelMass to all SPE small arms weapons in addons/compat_spe/CfgWeapons/weapons.hpp
• Apply ace_overheating_barrelMass to all SPEX small arms weapons in addons/compat_spex/CfgWeapons.hpp
• ace_overheating_barrelMass is determined by finding similar enough reproduction barrels or original barrels on sale on the internet
• Where no real barrels could be found, weights were taken from similar guns (i.e FM24 M29 similar to Bren Mk2 or K98, G43, FG42, and STG44 being similar due to caliber)
• Where units were not defined it was assumed the units were in pounds
• All barrelMass values were rounded to 2 significant digits

Barrel weight sources off of the internet

• https://www.1919a4.com/threads/turning-an-a4-barrel-into-an-a6-profile.27933/?utm_source=google&utm_medium=organic
• https://bmgparts.com/product/6508769/
• https://www.apexgunparts.com/bren-mk2-barrel-assembly-nos.html
• https://www.apexgunparts.com/german-k98-mauser-barrel-23-5-waffen-marked-8x57-fair.html
• https://www.ar15.com/forums/general/How-could-the-M1-Carbine-be-so-light-and-modern-guns-so-heavy-/5-2611211/?
• https://criterionbarrels.com/products/vintage-service/m1-garand/m1-garand-gi-contour-barrel-2/?v=0b3b97fa6688
• https://criterionbarrels.com/products/vintage-service/m1903/m1903-barrel/?v=0b3b97fa6688
• https://www.apexgunparts.com/mas36-308-project-barrel-gd.html
• https://criterionbarrels.com/products/vintage-service/lee-enfield/lee-enfield-no-4-barrel-2/?v=0b3b97fa6688
• https://www.apexgunparts.com/german-k98-mauser-barrel-23-5-waffen-marked-8x57-fair.html
• https://criterionbarrels.com/products/vintage-service/m1903/m1903-barrel/?v=0b3b97fa6688
• https://www.apexgunparts.com/mp40-barrel-9-75inch-npf-wwii-vg.html
• https://www.apexgunparts.com/thompson-m1-m1a1-barrel-10inch-new.html
• https://www.apexgunparts.com/m3-grease-gun-barrel-trunnion-good.html

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[Drofseh]

There is no need to add this if you're just making it 55% of the weapon's weight. 55% is already the default fallback value if there is no barrelMass config entry.
If you can get data for their actually barrel weights and want to add that then it'd be worthwhile.

[jpspider1]

There is no need to add this if you're just making it 55% of the weapon's weight. 55% is already the default fallback value if there is no barrelMass config entry. If you can get data for their actually barrel weights and want to add that then it'd be worthwhile.

Hi Drofseh, I did some very light research this evening and scrounged the various forums and gun brokerages for reproductions in similar calibers or original models. Where I could not find a barrel I used weapons in the same category or caliber. I updated my original post with links and some of my methodology. I hope this makes the PR more acceptable / valuable for the players.

[johnb432]

Thanks for the PR.

There are two things I'd like to ask:

• You sometimes specify sources, sometimes there are none. Why is that? It's best to be consistent.
• Could be similar to x maybe y comments are in my opinion not a good descriptor. could is too vague; either remove the comment or update it to something similar to Estimated slightly y to x

[jpspider1]

Thanks for the PR.

There are two things I'd like to ask:

• You sometimes specify sources, sometimes there are none. Why is that? It's best to be consistent.
• Could be similar to x maybe y comments are in my opinion not a good descriptor. could is too vague; either remove the comment or update it to something similar to Estimated slightly y to x

Some weapons I just couldn't find a source for the actual barrel mass sources so I used a could be similar to comment to justify the number. I grouped weapons that could be similar due to their classification

i.e a STEN Mk 2 and a MP40 are both sub machineguns with similar weights in real life
A FM 24 M29 and Bren gun are both light machine guns with similar weights in real life

I updated the comments to use the word 'estimated' because like above I just estimated or grouped similar weapon categories / weights together. I'd like to keep it there in case someone in the future who looks wants to see where I sourced my information from.