Repository navigation
resolve #579 #580 #581 #582: init event, creator fee tests, sell even… - #687
Merged
Merged
Conversation
…sslayerorg#582: init event, creator fee tests, sell event fields, protocol fee bps helper accesslayerorg#579: emit ContractInitializedEvent on first set_fee_config call with admin, protocol_fee_bps, protocol_fee_recipient, and initialized_at_ledger fields; add contract_initialization_event.rs integration tests accesslayerorg#580: add unit tests for creator fee bps computation — 500 bps on 1000 → 50, 250 bps on 1000 → 25, 100 bps on 999 floors to 9, 0 bps always returns 0 accesslayerorg#581: expand KeysSoldEvent with seller, creator_id, quantity, proceeds, ledger; update sell_key emission to populate new fields; add sell_event_fields.rs integration test asserting all five fields including proceeds formula match; update tests/events.rs to use new struct shape accesslayerorg#582: read_protocol_fee_bps helper and unit tests already present; no changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief closing comments:
Close #579
Close #580
Close #581
Close #582