Repository navigation
Add action button disabled cursor state pass - #217
Merged
Chucks1093 merged 1 commit intoApr 27, 2026
Merged
Conversation
- Add disabled:cursor-not-allowed to Button component for consistent disabled visual treatment - Add data-[disabled]:cursor-not-allowed to dropdown menu items for parity - Ensures all action buttons show not-allowed cursor when disabled - No changes to enable/disable logic
|
@temitope-007 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the normalization of disabled cursor/visual treatment for action buttons as requested in issue #210.
Changes Made
Button Component (
src/components/ui/button.tsx): Addeddisabled:cursor-not-allowedto the base button variants class, ensuring all buttons (including AsyncButton and other derivatives) display the not-allowed cursor when disabled.Dropdown Menu Items (
src/components/ui/dropdown-menu.tsx): Addeddata-[disabled]:cursor-not-allowedto the class names for DropdownMenuItem, DropdownMenuCheckboxItem, and DropdownMenuRadioItem to provide consistent disabled cursor treatment for menu action items.No Enable/Disable Logic Changes: The changes are purely visual and do not alter any existing disabled state logic or conditions.
Validation
Closes #210