Repository navigation
feat: add batch trade panel - #1044
Merged
Chucks1093 merged 2 commits intoSep 28, 2026
Merged
Conversation
|
@Killerjunior Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
5 tasks
Unclebaffa
added a commit
to Unclebaffa/accesslayer-client
that referenced
this pull request
Sep 28, 2026
…esslayerorg#1015 holding cap PR After the large dev rebase (20+ PRs merged including holding cap accesslayerorg#1015, batch trade accesslayerorg#1044, cooldown accesslayerorg#1043), several issues were introduced in BuySellKeyFlow and TradeDialog: - TradeDialog.tsx: priceImpactPercent guard was changed to currentSupply <= 0, incorrectly blocking valid impact calculations at supply=0 (new bonding curves). Reverted to < 0 to match calculateTradePriceImpact's own guard. Fixes 4 failing circuit breaker tests. - BuySellKeyFlow.tsx: Unused HoldingCapIndicator import and dead isCapLimitReached/isCapBreached/isCapExceeded useMemo blocks added but never rendered. Removed to fix ESLint no-unused-vars errors. - TradeDialog.tsx: Unused isCapExceeded combined variable removed (isCapLimitReached and isCapBreached used directly). - course.service.ts: holdingCap and maxHoldingCap properties missing from KeyConfig interface despite being accessed via keyConfig?.holdingCap in both BuySellKeyFlow and TradeDialog. Added with correct JSDoc (accesslayerorg#1015). Result: 31/31 circuit breaker tests pass, lint 0 errors, 0 TypeScript errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1029
Testing
pnpm lint— not runpnpm build— blocked: dependencies were unavailable and registry access failedChecklist