Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions YamlDotNet.Test/Serialization/SerializationTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2675,6 +2675,60 @@ public void SpacesGetQuotedWhenQuoteNecessaryStringsIsOn()
Assert.Equal(s, value);
}

// The default serializer already quotes a leading/trailing space; a tab is equally
// significant but was left plain and lost (or threw) on read-back (#732, #493).
public static IEnumerable<object[]> LeadingOrTrailingTabStrings => new[]
{
new object[] { "\tx" },
new object[] { "x\t" },
new object[] { "\t" },
new object[] { "\t," },
new object[] { "\tx\ty" },
new object[] { "\thello" },
new object[] { " \t " },
};

[Theory]
[MemberData(nameof(LeadingOrTrailingTabStrings))]
public void LeadingOrTrailingTabRoundtripsWithDefaultSerializer(string value)
{
var yaml = new SerializerBuilder().Build().Serialize(value);
var result = new DeserializerBuilder().Build().Deserialize<string>(yaml);
Assert.Equal(value, result);
}

[Fact]
public void TabCommaListRoundtripsWithoutThrowing()
{
// #732: "- \t,\n" is emitted plain, then rejected by the parser as its own output.
var value = new List<string> { "\t," };
var yaml = new SerializerBuilder().Build().Serialize(value);
var result = new DeserializerBuilder().Build().Deserialize<List<string>>(yaml);
Assert.Equal(value, result);
}

[Fact]
public void InteriorTabStaysPlainAndRoundtrips()
{
// The fix must not over-reach: an interior tab is safe plain and must stay unquoted.
var yaml = new SerializerBuilder().Build().Serialize("x\ty");
Assert.DoesNotContain("'", yaml);
Assert.DoesNotContain("\"", yaml);
var result = new DeserializerBuilder().Build().Deserialize<string>(yaml);
Assert.Equal("x\ty", result);
}

[Fact]
public void LeadingTrailingSpaceStillRoundtripsUnchanged()
{
foreach (var value in new[] { " x", "x ", " " })
{
var yaml = new SerializerBuilder().Build().Serialize(value);
var result = new DeserializerBuilder().Build().Deserialize<string>(yaml);
Assert.Equal(value, result);
}
}

[Flags]
private enum TestEnumAsNumber
{
Expand Down
2 changes: 1 addition & 1 deletion YamlDotNet/Core/Emitter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ private void AnalyzeScalar(Scalar scalar)
lineBreaks = true;
}

if (buffer.IsSpace())
if (buffer.IsWhite())
{
if (isFirst)
{
Expand Down