Repository navigation
Add signed webhook delivery and retry limits - #1599
Merged
Xoulomon merged 1 commit intoOct 21, 2026
Merged
Conversation
|
@DeePrincipal-dev-lang Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ll base the PR text on the pushed commit and its actual diff, including the test status and any relevant caveats, so the description is ready to paste without overstating verification.
Ran terminal command: git show --format=fuller --stat HEAD && git status --short
PR Title
Add signed webhook delivery, bounded retries, and idempotency keys
Description
Summary
Webhook deliveries now authenticate the exact JSON request body with HMAC-SHA256, identify events consistently across retries, and stop after a configurable maximum number of attempts. Failed deliveries are recorded in the dead-letter queue with their payload, final error, timestamps, and attempt count.
Changes
X-Webhook-Signature: sha256=<hex-digest>. The secret is not sent in the request.create_with_secretso callers can provide a per-subscription secret loaded from configuration. The existingcreatemethod remains available and generates a secret.Idempotency-Key, keeping the value stable across retries.Verification
git diff --checkand editor diagnostics passed.closes #1501