Skip to content

feat: Create an invariant to validated failed transactions - #7980

Draft
ximinez wants to merge 3 commits into
developfrom
ximinez/failure-invariant
Draft

feat: Create an invariant to validated failed transactions#7980
ximinez wants to merge 3 commits into
developfrom
ximinez/failure-invariant

Conversation

@ximinez

@ximinez ximinez commented Aug 8, 2026

Copy link
Copy Markdown
Contributor
  • refactor: Rewrite Transactor::operator() to early return
  • feat: Add an invariant to enforce failed transaction restrictions

High Level Overview of Change

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

ximinez added 2 commits August 7, 2026 20:32
- Rename "applied" to "canApply" to make it clearer that the transaction
  hasn't applied yet.
- After each step where the result can change, return if it's
  a non-claiming failure.
- Preserve logging.
@ximinez
ximinez force-pushed the ximinez/failure-invariant branch from 03c874a to 75ece33 Compare August 8, 2026 02:51
@ximinez ximinez added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DraftRunCI Normally CI does not run on draft PRs. This opts in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant