Add TransactionProposalCancel for Cosign (XLS-0103) - #7979
Open
ckeshava wants to merge 2 commits into
Open
Conversation
- While a proposal is live, only its Owner (the proposer) or its target (the proposed transaction's Account, or the Delegate named in it) may cancel it. - Once a proposal is terminal (its Expiration has passed, or the ledger has reached its proposed transaction's LastLedgerSequence), anyone may delete it and release the Owner's reserve. - Proposing a proposal transaction (Create or Cancel), directly or hidden inside a proposed Batch, is rejected (XLS-0103 §5.3.1). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Add the missing direct includes it reported, drop the unused AccountID include from the test, and keep STArray.h under an IWYU pragma: the range-for over getFieldArray needs the complete type, which the checker cannot see through the implicit begin/end use. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Adds the
TransactionProposalCanceltransaction (XLS-0103 §7, transaction type 94): deletes aTransactionProposalledger entry and releases the proposer's reserve. Resolves DEFI-996.Context of Change
Third transaction of the On-Chain Cosigner feature (XLS-0103), building on
TransactionProposalCreate(#7887).Account, or theDelegatenamed in it) may cancel:tecNO_PERMISSIONotherwise.Expirationhas passed, or the ledger has reached the proposed transaction'sLastLedgerSequence), anyone may delete it.ProposalIDistemMALFORMED; a missing entry istecNO_ENTRY.isProposalTxnow also rejects proposing a Cancel, or any proposal transaction hidden inside a proposed Batch (XLS-0103 §5.3.1).proposal::canceland a 19-case test suite covering authorization, terminal boundaries, Batch/multisign/sponsorship/ticket interactions, and nesting rejections.API Impact
libxrplchange (new amendment-gated transaction type,featureCosign)🤖 Generated with Claude Code