build: Reimagine linker warnings in different scenarios - #7974
Open
mathbunnyru wants to merge 2 commits into
Open
build: Reimagine linker warnings in different scenarios#7974mathbunnyru wants to merge 2 commits into
mathbunnyru wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the build treats linker warnings across environments: making linker warnings fatal in CI on macOS/Linux to catch real issues early, while reducing local macOS noise from deployment target mismatch warnings (with special handling for the Nix toolchain).
Changes:
- In CI on macOS/Linux, add linker flags to treat all linker warnings as errors (
-fatal_warningson macOS,--fatal-warningson Linux). - On local macOS, suppress deployment target mismatch warnings; under Nix, silence all linker warnings due to limited per-warning control.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
(macOS + Linux, CI) Warnings will be fatal - this would allow us to catch problem.
(macOS, locally) Try to disable specific warnings about deployment_target_mismatches, in Nix silence all (there is no separate option)
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)