Skip to content

build: Reimagine linker warnings in different scenarios - #7974

Open
mathbunnyru wants to merge 2 commits into
XRPLF:developfrom
mathbunnyru:linker_warnings
Open

build: Reimagine linker warnings in different scenarios#7974
mathbunnyru wants to merge 2 commits into
XRPLF:developfrom
mathbunnyru:linker_warnings

Conversation

@mathbunnyru

Copy link
Copy Markdown
Contributor

High Level Overview of Change

(macOS + Linux, CI) Warnings will be fatal - this would allow us to catch problem.
(macOS, locally) Try to disable specific warnings about deployment_target_mismatches, in Nix silence all (there is no separate option)

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how the build treats linker warnings across environments: making linker warnings fatal in CI on macOS/Linux to catch real issues early, while reducing local macOS noise from deployment target mismatch warnings (with special handling for the Nix toolchain).

Changes:

  • In CI on macOS/Linux, add linker flags to treat all linker warnings as errors (-fatal_warnings on macOS, --fatal-warnings on Linux).
  • On local macOS, suppress deployment target mismatch warnings; under Nix, silence all linker warnings due to limited per-warning control.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mathbunnyru mathbunnyru added the Full CI build Run all CI configurations, no matter what label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Full CI build Run all CI configurations, no matter what

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants