fix: Add zero keylet check in credential - #7971
Open
yinyiqian1 wants to merge 6 commits into
Open
Conversation
yinyiqian1
force-pushed
the
fix-zero-credential
branch
3 times, most recently
from
August 6, 2026 18:32
31564ae to
12106c8
Compare
yinyiqian1
marked this pull request as ready for review
August 6, 2026 18:32
yinyiqian1
changed the title
yinyiqian1
force-pushed
the
fix-zero-credential
branch
from
August 6, 2026 18:35
12106c8 to
2f97a23
Compare
mvadari
reviewed
Aug 6, 2026
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
mvadari
reviewed
Aug 7, 2026
| { | ||
| // LCOV_EXCL_START | ||
| JLOG(j.trace()) << "Zero credential ID."; | ||
| return tecBAD_CREDENTIALS; |
Contributor
There was a problem hiding this comment.
If this is already checked in preflight, this should return a more severe error, like tecINTERNAL
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
credential should check if the id is zero before querying the ledger.
Otherwise, it will trigger assertion
High Level Overview of Change
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)