Skip to content

test: Fix LoanBatch broker cover rates and schedule overflow #7967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tapanito wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −2
Open

test: Fix LoanBatch broker cover rates and schedule overflow #7967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/test/app/lending/LoanMisc_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,14 +473,21 @@ class LoanBatch_test : public LoanTestBase
TenthBips16 const managementFeeRate{managementFeeRateDist_(engine_)};
auto const serviceFee = serviceFeeDist_(engine_);
TenthBips32 interest{interestRateDist_(engine_)};
auto const payTotal = paymentTotalDist_(engine_);
auto payTotal = paymentTotalDist_(engine_);
auto const payInterval = paymentIntervalDist_(engine_);
// The end of the last payment's grace period must fit in a 32-bit
// ripple-epoch timestamp, or LoanSet fails with tecKILLED. Cap the
// schedule well below that horizon (2e9 seconds is roughly 63 years,
// leaving ample headroom over the ledger start date).
constexpr std::uint32_t kMaxScheduleSeconds = 2'000'000'000;
payTotal = std::min(payTotal, static_cast<int>(kMaxScheduleSeconds / payInterval));

BrokerParameters const brokerParams{
.vaultDeposit = principalRequest * 10,
.debtMax = 0,
.coverRateMin = TenthBips32{0},
.managementFeeRate = managementFeeRate};
.managementFeeRate = managementFeeRate,
.coverRateLiquidation = TenthBips32{0}};
LoanParameters const loanParams{
.account = lender,
.counter = borrower,
Expand Down
Loading