Skip to content

test: Make Drop50 message drop deterministic in LedgerReplayer test #7964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pratikmankawde wants to merge 2 commits into
base: develop
Choose a base branch
from
+8 −11
Open

test: Make Drop50 message drop deterministic in LedgerReplayer test #7964

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83457e7
test: Make Drop50 message drop deterministic in LedgerReplayer test
pratikmankawde Aug 6, 2026
54547c7
minor comment update
pratikmankawde Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/test/app/LedgerReplay_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@

#include <xrpl/basics/Slice.h>
#include <xrpl/basics/base_uint.h>
#include <xrpl/basics/random.h>
#include <xrpl/beast/net/IPAddress.h>
#include <xrpl/beast/net/IPEndpoint.h>
#include <xrpl/beast/unit_test/suite.h>
Expand All @@ -53,6 +52,7 @@
#include <xrpl.pb.h>

#include <algorithm>
#include <atomic>
#include <cassert>
#include <chrono>
#include <cstddef>
Expand Down Expand Up @@ -443,17 +443,16 @@ struct TestPeerSet : public PeerSet
protocol::MessageType type,
std::shared_ptr<Peer> const& peer) override
{
int dropRate = 0;
if (behavior == PeerSetBehavior::Drop50)
{
dropRate = 50;
}
else if (behavior == PeerSetBehavior::DropAll)
{
dropRate = 100;
}
if (behavior == PeerSetBehavior::DropAll)
return;

if (randInt(1, 100) <= dropRate)
// Drop every other message deterministically. A random 50% drop
// could drop all (1 + kSubTaskMaxTimeouts) sends of a subtask
// (probability (1/2)^11 per subtask), failing the whole task and
// making the test flaky. Alternating drops still exercise the
// timeout/retry path while guaranteeing every subtask eventually
// gets a reply.
if (behavior == PeerSetBehavior::Drop50 && sendCount++ % 2 == 0)
return;

switch (type)
Expand Down Expand Up @@ -498,6 +497,7 @@ struct TestPeerSet : public PeerSet
LedgerReplayMsgHandler& remote;
std::shared_ptr<TestPeer> dummyPeer;
PeerSetBehavior behavior;
std::atomic<int> sendCount{0};
};

/**
Expand Down
Loading