feat: Enable key rotation in MPTokenIssuanceSet - #7960
Open
yinyiqian1 wants to merge 1 commit into
Open
Conversation
yinyiqian1
force-pushed
the
allow-key-update
branch
5 times, most recently
from
August 6, 2026 14:54
d177232 to
2544bde
Compare
yinyiqian1
marked this pull request as ready for review
August 6, 2026 14:56
yinyiqian1
force-pushed
the
allow-key-update
branch
2 times, most recently
from
August 6, 2026 15:17
422c0eb to
18021bc
Compare
yinyiqian1
force-pushed
the
allow-key-update
branch
from
August 6, 2026 15:40
18021bc to
92c27da
Compare
oleks-rip
reviewed
Aug 7, 2026
| bool const sleHasAuditorKey = sleMptIssuance->isFieldPresent(sfAuditorEncryptionKey); | ||
|
|
||
| // cannot update issuer public key | ||
| if (ctx.tx.isFieldPresent(sfIssuerEncryptionKey) && |
Contributor
There was a problem hiding this comment.
Best practices for amendments are using one amendment enabled block and one amendment disabled block, even if they are similar, instead of spreading amendment through the code.
|
|
||
| // Only increment the auditor key epoch on a rotation. First time registration leaves it | ||
| // absent. | ||
| bool const isRotation = sle->isFieldPresent(sfAuditorEncryptionKey); |
Contributor
There was a problem hiding this comment.
These 2 have the same code, why not make helper. or lambda?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-ConfidentialKeyRotation,
MPTokenIssuanceSetrejects any attempt to modify an existingIssuerEncryptionKey/AuditorEncryptionKey, and an auditor key can never be provided without the issuer key (temMALFORMEDin preflight).Post-ConfidentialKeyRotation:
Epoch:
High Level Overview of Change
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)