TransactionProposalCreate edge cases and tests - #7958
Open
Kassaking7 wants to merge 6 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ckeshava
approved these changes
Aug 5, 2026
shawnxie999
reviewed
Aug 6, 2026
| return temINVALID; | ||
| } | ||
|
|
||
| if (proposedTx.isFieldPresent(sfFlags) && |
Contributor
There was a problem hiding this comment.
I think we still need proposedTx.isFieldPresent(sfFlags) check, otherwise if the field doesn't exist it will throw. What if we move the STTx construction (line 128) to the start of preflight? would it avoid having need to check the existence of the fields
shawnxie999
reviewed
Aug 6, 2026
Comment on lines
103
to
104
| if (!proposedTx.isFieldPresent(sfTicketSequence) || proposedTx.getFieldU32(sfSequence) != 0) | ||
| return temSEQ_AND_TICKET; |
Contributor
There was a problem hiding this comment.
based on recent discussion, we need to reserve ticket, so we should check if the ticket exists
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)