Skip to content

Add test comparing WebP and JPEG sub-size dimensions #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonali195 wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Add test comparing WebP and JPEG sub-size dimensions #2696

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e8daa6
Add test comparing WebP and JPEG sub-size dimensions
sonali195 Oct 6, 2026
ebcc3db
Fix test formatting for coding standards
sonali195 Oct 6, 2026
9802832
Merge branch 'trunk' into fix/issue-1234-short-description
sonali195 Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 33 additions & 19 deletions plugins/webp-uploads/tests/test-load.php
View file
Open in desktop
Comment thread
mukeshpanchal27 marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -316,34 +316,48 @@ static function () {
* @covers ::get_attached_file
* @covers ::wp_get_attachment_metadata
*/
public function test_it_should_remove_the_generated_webp_images_when_the_attachment_is_deleted(): void {
/**
* WebP sub-sizes should have the same dimensions as the JPEG sub-sizes in the metadata.
*
* @covers ::wp_get_attachment_metadata
*/
public function test_it_should_create_webp_subsizes_with_the_same_dimensions_as_the_jpeg_subsizes(): void {
$this->opt_in_to_jpeg_and_webp();

// The leaves image is 1080 pixels wide, so this filter ensures a -scaled version is created.
add_filter(
'big_image_size_threshold',
static function () {
return 850;
}
);

$attachment_id = self::factory()->attachment->create_upload_object(
TESTS_PLUGIN_DIR . '/tests/data/images/leaves.jpg'
);
$metadata = wp_get_attachment_metadata( $attachment_id );
$directory = dirname( (string) get_attached_file( $attachment_id ) );

$file = get_attached_file( $attachment_id, true );
$dirname = pathinfo( $file, PATHINFO_DIRNAME );

$this->assertIsString( $file );
$this->assertFileExists( $file );

$metadata = wp_get_attachment_metadata( $attachment_id );
$sizes = array( 'thumbnail', 'medium' );

$this->assertFileExists( path_join( $dirname, $metadata['sources']['image/webp']['file'] ) );
$this->assertIsArray( $metadata );
$this->assertArrayHasKey( 'sizes', $metadata );

foreach ( $sizes as $size_name ) {
$this->assertImageHasSizeSource( $attachment_id, $size_name, 'image/webp' );
$this->assertFileExists( path_join( $dirname, $metadata['sizes'][ $size_name ]['sources']['image/webp']['file'] ) );
}
$checked = 0;
foreach ( $metadata['sizes'] as $size_name => $size_data ) {
if ( ! isset( $size_data['sources']['image/webp']['file'] ) ) {
continue;
}

wp_delete_attachment( $attachment_id );
$webp_path = path_join( $directory, $size_data['sources']['image/webp']['file'] );
$this->assertFileExists( $webp_path );

foreach ( $sizes as $size_name ) {
$this->assertFileDoesNotExist( path_join( $dirname, $metadata['sizes'][ $size_name ]['sources']['image/webp']['file'] ) );
$image_size = wp_getimagesize( $webp_path );
$this->assertIsArray( $image_size, "Could not read the WebP size for {$size_name}." );
$this->assertSame( $size_data['width'], $image_size[0], "WebP width differs from the JPEG width for {$size_name}." );
$this->assertSame( $size_data['height'], $image_size[1], "WebP height differs from the JPEG height for {$size_name}." );
++$checked;
}

$this->assertFileDoesNotExist( path_join( $dirname, $metadata['sources']['image/webp']['file'] ) );
$this->assertGreaterThan( 0, $checked, 'Expected at least one WebP sub-size to be checked.' );
}

/**
Expand Down
Loading