Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ about: Suggest an idea for this project

## Feature Description

<!-- Please describe clear and concisely which problem the feature would solve or which publisher needs it would address. -->
<!-- Please describe clearly and concisely which problem the feature would solve or which publisher needs it would address. -->
2 changes: 1 addition & 1 deletion .github/workflows/props-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
issue_comment:
types:
- created
# This event will run everytime a new PR review is initially submitted.
# This event will run every time a new PR review is initially submitted.
pull_request_review:
types:
- submitted
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ In general, indentation should use tabs. Refer to `.editorconfig` in the project

It is expected for new code introduced to have `@since` tags with the `n.e.x.t` placeholder version. It will get replaced with the actual version at the time of release. Do not add any code review comments to such code.

Every file, function, class, method constant, and global variable must have an associated docblock with a `@since` tag.
Every file, function, class, method, constant, and global variable must have an associated docblock with a `@since` tag.

### PHP

Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ In general, all code must follow the [WordPress Coding Standards and best practi
## Guidelines

- As with all WordPress projects, we want to ensure a welcoming environment for everyone. With that in mind, all contributors are expected to follow our [Code of Conduct](https://make.wordpress.org/handbook/community-code-of-conduct/).
- All WordPress projects are [licensed under the GPLv2+](/LICENSE), and all contributions to the [Performance Lab](https://wordpress.org/plugins/performance-lab/) plugin will be released under the GPLv2+ license. You maintain copyright over any contribution you make, and by submitting a pull request, you are agreeing to release that contribution under the GPLv2+ license.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check this one, I think /LICENSE is right already? what do our other WordPress projects use?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like GitHub's markdown parser already resolves this correctly. Otherwise, this would be a link to https://github.com/LICENSE but no, it links correctly already to https://github.com/WordPress/performance/blob/trunk/LICENSE

In any case, ./LICENSE seems less confusing.

- All WordPress projects are [licensed under the GPLv2+](./LICENSE), and all contributions to the [Performance Lab](https://wordpress.org/plugins/performance-lab/) plugin will be released under the GPLv2+ license. You maintain copyright over any contribution you make, and by submitting a pull request, you are agreeing to release that contribution under the GPLv2+ license.

## Use of AI Tools

Expand All @@ -24,4 +24,4 @@ For more, please see the [WordPress AI Guidelines](https://make.wordpress.org/ai

## Reporting Security Issues

Please see [SECURITY.md](/SECURITY.md).
Please see [SECURITY.md](./SECURITY.md).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this changes?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should keep this change. ./SECURITY.md is a clearer and more reliable relative link to the security document.

2 changes: 1 addition & 1 deletion plugins/auto-sizes/readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Contributions are always welcome! Learn more about how to get involved in the [C
**Enhancements**

* Accurate sizes: Add ancestor block context for image and cover block that help in sizes calculate. ([1795](https://github.com/WordPress/performance/pull/1795))
* Accurate sizes: Calculate sizes base on ancestor block context. ([1818](https://github.com/WordPress/performance/pull/1818))
* Accurate sizes: Calculate sizes based on ancestor block context. ([1818](https://github.com/WordPress/performance/pull/1818))

= 1.4.0 =

Expand Down
2 changes: 1 addition & 1 deletion plugins/optimization-detective/detect.js
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ async function getAlreadySubmittedSessionStorageKey(
) {
if ( ! win.crypto || ! win.crypto.subtle ) {
warn(
'Unable to generate sessionStorage key for already-submitted URL since crypto is not available, likely due to to the page not being served via HTTPS.'
'Unable to generate sessionStorage key for already-submitted URL since crypto is not available, likely due to the page not being served via HTTPS.'
);
return null;
}
Expand Down
4 changes: 2 additions & 2 deletions plugins/optimization-detective/docs/extensions.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Stable plugins for use in production from the WordPress.org Plugin Directory:
* [Image Prioritizer](https://wordpress.org/plugins/image-prioritizer/): Prioritizes the loading of images and videos based on how visible they are to actual visitors; adds fetchpriority and applies lazy loading.
* [Embed Optimizer](https://wordpress.org/plugins/embed-optimizer/): Optimizes the performance of embeds through lazy-loading, adding dns-prefetch links, and reserving space to reduce layout shifts.

Experimental plugins being explored exploration, from repositories on GitHub:
Experimental plugins being explored, from repositories on GitHub:

* [Optimization Detective Content Visibility](https://github.com/westonruter/od-content-visibility): Applies content-visibility to posts in The Loop to improve rendering performance.
* [Optimization Detective Intrinsic Dimensions](https://github.com/westonruter/od-intrinsic-dimensions): Supplies width and height attributes to IMG and VIDEO tags that lack them according to their intrinsic dimensions. This reduces Cumulative Layout Shift (CLS).
Expand All @@ -52,4 +52,4 @@ For development and debugging, also on GitHub:
* [Optimization Detective Store Query Vars](https://github.com/westonruter/od-store-query-vars): Stores the Query Vars with a URL Metric in the Optimization Detective plugin. This is useful for debugging URL Metrics, in particular what the slug was computed from.
* [Optimization Detective Store User Agent](https://github.com/westonruter/od-store-user-agent): Stores the User Agent with a URL Metric in the Optimization Detective plugin. This is useful for debugging URL Metrics, in particular to understand what device has a given viewport's dimensions.
* [Optimization Detective Dev Mode](https://github.com/westonruter/od-dev-mode): Adds filters to facilitate development of the Optimization Detective plugin.
* [Optimization Detective Default Disabled](https://github.com/westonruter/od-default-disabled): Disables functionality in Optimization Detective by default unless the `?optimization_detective_enabled=1` query parameter is present. This allows you for troubleshooting issues on a live site without visitors seeing a broken experience.
* [Optimization Detective Default Disabled](https://github.com/westonruter/od-default-disabled): Disables functionality in Optimization Detective by default unless the `?optimization_detective_enabled=1` query parameter is present. This allows you to troubleshoot issues on a live site without visitors seeing a broken experience.
4 changes: 2 additions & 2 deletions plugins/optimization-detective/docs/hooks.md
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ Filters how long the current IP is locked from submitting another URL metric sto
Filtering the TTL to zero will disable any URL Metric storage locking. This is useful, for example, to disable locking when a user is logged in with code like the following:

```php
add_filter( 'od_metrics_storage_lock_ttl', function ( int $ttl ): int {
add_filter( 'od_url_metric_storage_lock_ttl', function ( int $ttl ): int {
Comment thread
westonruter marked this conversation as resolved.
return is_user_logged_in() ? 0 : $ttl;
} );
```
Expand All @@ -253,7 +253,7 @@ By default, the TTL is zero (0) for authorized users and sixty (60) for everyone
During development this is useful to set to zero, so you can quickly collect new URL Metrics by reloading the page without having to wait for the storage lock to release:

```php
add_filter( 'od_metrics_storage_lock_ttl', function ( int $ttl ): int {
add_filter( 'od_url_metric_storage_lock_ttl', function ( int $ttl ): int {
Comment thread
westonruter marked this conversation as resolved.
return 0;
} );
```
Expand Down
2 changes: 1 addition & 1 deletion plugins/optimization-detective/docs/introduction.md
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ As shown in the Background section above, WordPress core can incorrectly add `fe
Here Image Prioritizer does the following:

* Remove `fetchpriority=high` from the `IMG` tag since it is not the common LCP element across all viewport sizes (or even in one viewport).
* Add preload links with `fetchpriority=high` with media queries to target viewport-specific LCP images:
* Add preload links with `fetchpriority=high` using media queries to target viewport-specific LCP images:

```html
<link
Expand Down
2 changes: 1 addition & 1 deletion plugins/webp-uploads/readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -234,4 +234,4 @@ By default, the Modern Image Formats plugin will only generate WebP versions of

= 2.0.0 =

This release adds support for AVIF images and enables selecting the the output image format to choose between WebP and AVIF when both are available. AVIF is used as the default when the server supports it.
This release adds support for AVIF images and enables selecting the output image format to choose between WebP and AVIF when both are available. AVIF is used as the default when the server supports it.
Loading