Repository navigation
Avoid npx when running build and test tooling - #2664
Merged
sarthak-19 merged 1 commit intoSep 7, 2026
Merged
Conversation
npx downloads and runs the install scripts of a package (and its dependencies) from the registry when it is not found locally, which is a supply-chain risk for build/test tooling. Replace each npx call with npm exec --no --, which only runs an already-installed local binary and fails if the package is missing, instead of installing it. Fixes WordPress#2654
westonruter
approved these changes
Sep 7, 2026
sarthak-19
marked this pull request as ready for review
September 7, 2026 19:33
sarthak-19
requested review from
mukeshpanchal27 and
thelovekesh
as code owners
September 7, 2026 19:33
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @sarthak.jaiswal@rtCamp.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npxdownloads a package (and its dependencies) from the registry and runs their install scripts when the package isn't found locally. Each such call in build/test tooling is a point where a compromised package could run code during a build. This replaces eachnpxcall withnpm exec --no --, which only runs an already-installed local binary and fails instead of installing when the package is missing.This mirrors the fix already applied in WordPress/wordpress-develop#13021 for the same class of issue.
Fixes #2654
Changes
.husky/pre-commit:npx lint-staged→npm exec --no -- lint-staged.wp-env.test.json:npx wp-env ...→npm exec --no -- wp-env ....github/workflows/e2e-test.yml:npx playwright install chromium --with-deps→npm exec --no -- playwright install chromium --with-depsAll three packages (
lint-staged,@wordpress/env,@playwright/test) are already devDependencies inpackage.json, so this is behavior-neutral.Test plan
npxusages outsidenode_modules/package-lock.json— none found.npm exec --no -- lint-stagedresolves the local binary successfully.e2e-test.ymlworkflow still installs Playwright and runs e2e tests successfully.