Skip to content

Avoid npx when running build and test tooling - #2664

Merged
sarthak-19 merged 1 commit into
WordPress:trunkfrom
sarthak-19:fix/avoid-npx-in-build-tooling
Sep 7, 2026
Merged

sarthak-19 merged 1 commit into
WordPress:trunkfrom
sarthak-19:fix/avoid-npx-in-build-tooling

Conversation

@sarthak-19

@sarthak-19 sarthak-19 commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

npx downloads a package (and its dependencies) from the registry and runs their install scripts when the package isn't found locally. Each such call in build/test tooling is a point where a compromised package could run code during a build. This replaces each npx call with npm exec --no --, which only runs an already-installed local binary and fails instead of installing when the package is missing.

This mirrors the fix already applied in WordPress/wordpress-develop#13021 for the same class of issue.

Fixes #2654

Changes

  • .husky/pre-commit: npx lint-staged → npm exec --no -- lint-staged
  • .wp-env.test.json: npx wp-env ... → npm exec --no -- wp-env ...
  • .github/workflows/e2e-test.yml: npx playwright install chromium --with-deps → npm exec --no -- playwright install chromium --with-deps

All three packages (lint-staged, @wordpress/env, @playwright/test) are already devDependencies in package.json, so this is behavior-neutral.

Test plan

  • Searched the repo for all remaining npx usages outside node_modules/package-lock.json — none found.
  • Verified npm exec --no -- lint-staged resolves the local binary successfully.
  • Confirmed the pre-commit hook runs correctly with the updated command (observed during this PR's own commit).
  • CI: confirm the e2e-test.yml workflow still installs Playwright and runs e2e tests successfully.

npx downloads and runs the install scripts of a package (and its
dependencies) from the registry when it is not found locally, which is
a supply-chain risk for build/test tooling. Replace each npx call with
npm exec --no --, which only runs an already-installed local binary
and fails if the package is missing, instead of installing it.

Fixes WordPress#2654
@sarthak-19 sarthak-19 added no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature labels Sep 7, 2026
@sarthak-19
sarthak-19 marked this pull request as ready for review September 7, 2026 19:33
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @sarthak.jaiswal@rtCamp.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: sarthak.jaiswal@rtCamp.com.

Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sarthak-19
sarthak-19 merged commit b94c0c7 into WordPress:trunk Sep 7, 2026
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid npx when running build and test tooling

2 participants