Repository navigation
Conversation
…ces. - Remove inner whitespace from attribute selectors (`[ tone=... ]`) in `src/plugins/drafts-widget/styles.css`. - esbuild's CSS minifier parser rejects whitespace immediately following the opening bracket in attribute selectors, logging `[css-syntax-error]` warnings during production builds. - Removes the whitespace so the rules parse cleanly, letting esbuild minify them normally with unquoted identifier normalization `[tone=success]`). Also updates the tracked built CSS assets.
KarunyaChavan
marked this pull request as ready for review
October 23, 2026 11:43
epeicher
approved these changes
Oct 30, 2026
epeicher
left a comment
epeicher
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @KarunyaChavan for fixing those! I have reviewed the changes and they LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request eliminates the three
[css-syntax-error] Expected identifier but found whitespacewarnings emitted by esbuild during production CSS minification of the drafts widget. By removing inner whitespace from attribute selectors ([ tone=... ]) insrc/plugins/drafts-widget/styles.cssand updating the tracked build outputs, the CSS now adheres to standard selector syntax and builds cleanly without warnings.Closes #1044
Why ?
npm run build/npm run build:widget-drafts).src/plugins/drafts-widget/styles.css, selectors were written with spaces inside the brackets (e.g.,.dm-drafts__notice[ tone='success' ]). Esbuild's CSS parser strictly expects an attribute identifier token immediately after[and flags any leading whitespace as a[css-syntax-error].What Changed ?
src/plugins/drafts-widget/styles.css:[tone='success'],[tone='warning'],[tone='error'], and[tone='danger']attribute selectors.assets/js/widget-drafts.css:SCRIPT_DEBUGis active.assets/js/widget-drafts.min.css:[tone=success]).Steps for Testing
npm run build:widget-drafts(ornpm run build).[css-syntax-error]messages during the minification step.npm run test:js -- tests/vitest/drafts-widget.test.ts.