WIRE-291: prevalidate underwriter UIC signatures - #543
Open
huangminghuang wants to merge 1 commit into
Open
Conversation
Disqualify malformed or unauthorized UIC candidates without aborting consensus dispatch. Fail underwriter startup when its WIRE provider cannot emit the canonical K1 shape accepted by the depot. Refs: WIRE-291 Change-Id: Ife7e32511f93ae7600bca8ef640deb8367884206
huangminghuang
marked this pull request as ready for review
July 30, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavior and security model
Malformed UIC data is isolated at the candidate boundary. Missing, truncated, oversized, unsupported-type, invalid-curve, digest-encoding, recovery, and unauthorized-key failures return typed results instead of aborting consensus dispatch. A disqualified candidate remains reclaimable: a new matching commit re-arms it for validation.
The rejection marker records the candidate claim as claimed_underwriter and includes the proven outpost id and leg. It does not claim that the candidate field identifies an authenticated depot submitter.
The plugin and depot now share the same K1-only contract. Startup exercises the configured provider before cron registration, while runtime UIC construction defensively rechecks the provider and packed output before paying outpost gas.
Tests and validation
Known unrelated baseline failures
The broader contract run passed 508/509 tests; sysio_msig_tests/big_transaction remains the existing base_per_transaction_net_usage schema-drift failure. The broader CTest sample passed 311/339; the remaining existing failures cluster around the freshly compiled sysio.system init/schema and RAM-baseline drift and are not changed by this PR.
Jira
WIRE-291