Repository navigation
chore/remove-bloomsky: no more BloomSky connection box (#87) - #189
Merged
Merged
Conversation
…orted devices (issue #87)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #87. The piste of the issue was: hide it from the add-station screen, mark existing stations as not working, remove it in a later version. The first two were done in #97; this adds the two places which still presented BloomSky as working: the connection box of the services settings (shown now only when an account is still stored, to disconnect it) and the readme list of supported devices (readme.txt and readme.md). Checked in the browser: box absent when not connected, present when connected. The removal of the code (library, classes, options, task) stays for a later version, as the issue says.