Skip to content

fix(protocol): advertise package version consistently - #329

Merged
Waishnav merged 3 commits into
mainfrom
fix/protocol-version-metadata
Sep 8, 2026
Merged

Waishnav merged 3 commits into
mainfrom
fix/protocol-version-metadata

Conversation

@Waishnav

@Waishnav Waishnav commented Sep 8, 2026

Copy link
Copy Markdown
Owner

DevSpace still advertises stale hard-coded versions to MCP clients and the Codex app-server even though the CLI and ACP path already derive the release version from package metadata. That makes protocol metadata drift from the version actually being shipped.

Centralize the package version in one runtime module and use it for MCP server info, Codex client info, and the existing ACP client info. The release workflow can now set package.json once and have every protocol surface advertise that same version.

Summary by CodeRabbit

  • Bug Fixes
    • Version information now stays consistent across the server and connected runtime components.
    • Reported client and server versions now update automatically with the package version instead of relying on outdated hardcoded values.
    • Invalid or missing package version information is detected during startup.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 45b8cdea-a655-43ed-a0b9-8232409c3984

📥 Commits

Reviewing files that changed from the base of the PR and between a9f930d and 914d943.

📒 Files selected for processing (4)
  • src/local-agent-acp.ts
  • src/local-agent-codex.ts
  • src/server.ts
  • src/version.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The change adds a validated DEVSPACE_VERSION export from package.json. ACP initialization, Codex initialization, and MCP server information now use this shared version instead of locally resolved or hardcoded values.

Changes

Version reporting

Layer / File(s) Summary
Validated version source
src/version.ts
Loads the package version with createRequire, validates it, and exports DEVSPACE_VERSION.
Protocol metadata integration
src/local-agent-acp.ts, src/local-agent-codex.ts, src/server.ts
Uses DEVSPACE_VERSION for ACP and Codex initialization metadata and MCP server information.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 914d9

ACP, Codex, and MCP metadata now consistently report the package manifest version through one validated source. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: consistent package version reporting across protocol metadata.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/protocol-version-metadata

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the version bright
One source now guides each protocol flight
ACP and Codex share the sign
MCP reports the same design
Three paths hop in matching line

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Summary

  • Centralizes the DevSpace package version in one runtime module.
  • Uses the package-derived version consistently in MCP, ACP, and Codex protocol metadata.
  • No issues found; the change is safe to merge.

Confidence Score: 5/5

Safe to merge: all changed protocol metadata paths report the package version and the targeted checks pass.

No actionable findings were identified.

Files Needing Attention: None.

T-Rex T-Rex Logs

What T-Rex did

  • I ran a focused runtime check for the changed protocol paths using package version 1.0.8; MCP reported serverInfo.version 1.0.8, and ACP and Codex reported clientInfo.version 1.0.8; the pre-change revision showed MCP 0.1.0 and Codex 1.0.7.
  • Type checking passed and the targeted ACP, Codex, and server tests completed, with 19 tests passing and 0 failing.
  • Finding status is no issue after the focused checks, and the evidence confirms the corrected behavior across MCP, ACP, and Codex with all targeted tests passing.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "fix(codex): advertise package version" | Re-trigger Greptile

@Waishnav
Waishnav merged commit e5e1251 into main Sep 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant