Skip to content

ci: reduce duplicate validation after merge - #317

Merged
Waishnav merged 1 commit into
mainfrom
ci/reduce-duplicate-validation
Sep 7, 2026
Merged

Waishnav merged 1 commit into
mainfrom
ci/reduce-duplicate-validation

Conversation

@Waishnav

@Waishnav Waishnav commented Sep 7, 2026

Copy link
Copy Markdown
Owner

PR CI currently runs the full Linux/macOS/Windows matrix again after merge, and the release workflow repeats typechecking and tests once more. That adds cost without materially increasing confidence for the normal PR path.

PRs now keep the full three-OS matrix, while pushes to main run the same smoke job only on Ubuntu so direct pushes and the exact-SHA release gate still have a safety net. Releases continue to verify the versioned packed artifact, but no longer rerun typechecking and tests that already passed on the exact main commit.

Summary by CodeRabbit

  • Chores
    • Updated automated quality checks to run across supported operating systems for pull requests, while streamlining checks for changes merged to the main branch.
    • Adjusted the release process by removing intermediate type-checking and test steps while retaining package validation, artifact checks, and publication safeguards.
  • User Impact
    • No changes to product functionality or the end-user experience.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 0540b6c6-772b-4b93-a07e-c59d8849c491

📥 Commits

Reviewing files that changed from the base of the PR and between 6c0e3a4 and 79ec73a.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/release.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/release.yml

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The CI smoke matrix now uses three operating systems for pull requests and Ubuntu only for pushes to main. The release workflow no longer runs typecheck and test steps after setting the package version.

Changes

Workflow execution updates

Layer / File(s) Summary
Event-specific CI matrix
.github/workflows/ci.yml
The smoke job selects all three operating systems for pull_request events and only ubuntu-latest for pushes to main.
Release workflow step removal
.github/workflows/release.yml
The release workflow removes the Typecheck and Test steps before the package-install smoke test.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 79ec7

CI now avoids redundant macOS and Windows smoke runs after merging while retaining the full cross-platform pull-request matrix and release artifact smoke validation. No current merge-blocking risk remains.

Suggested reviewers: rokurolize

Poem

A rabbit checks the workflow lane
Three OS hops for pull requests in rain
Main takes Ubuntu down the track
Release skips two steps and circles back
Green checks twitch their ears with cheer

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: reducing duplicate CI validation after pull requests merge. It covers both the reduced post-merge OS matrix and the removed duplicate release checks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/reduce-duplicate-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR reduces redundant post-merge and release validation while retaining an exact-commit release gate.

  • Pull requests continue to run the complete Ubuntu, macOS, and Windows matrix.
  • Pushes to main run the CI job only on Ubuntu.
  • Releases still require successful main-branch CI for the exact release SHA.
  • Release packaging continues to rebuild and smoke-test the versioned packed artifact.

Confidence Score: 5/5

The PR appears safe to merge because every released SHA remains gated by successful main CI, and the release-built package is still smoke-tested.

No actionable failure remains: pull requests retain cross-platform coverage, exact main SHAs retain Ubuntu typechecking and tests, and releases retain exact-SHA gating plus packed-artifact validation.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Selects the full three-platform matrix for pull requests and an Ubuntu-only matrix for main pushes while preserving all validation steps.
.github/workflows/release.yml Removes redundant source typechecking and tests while retaining exact-SHA CI gating and validation of the versioned packed artifact.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    PR[Pull request] --> Matrix[CI: Ubuntu, macOS, Windows]
    Merge[Push to main] --> Ubuntu[CI: Ubuntu]
    Ubuntu --> Checks[Typecheck, tests, package smoke test, doctor]
    Checks --> Gate{Exact SHA CI succeeded?}
    Dispatch[Manual release dispatch on main] --> Gate
    Gate -->|Yes| Version[Set release version]
    Gate -->|No| Stop[Stop release]
    Version --> Package[Build and pack artifact]
    Package --> Smoke[Package installation smoke test]
    Smoke --> Publish[Publish release]
Loading

Reviews (1): Last reviewed commit: "ci: reduce duplicate validation after me..." | Re-trigger Greptile

@Waishnav
Waishnav merged commit 521e1fa into main Sep 7, 2026
5 checks passed
@Waishnav
Waishnav deleted the ci/reduce-duplicate-validation branch September 7, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant