ci: reduce duplicate validation after merge - #317
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe CI smoke matrix now uses three operating systems for pull requests and Ubuntu only for pushes to ChangesWorkflow execution updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to CI now avoids redundant macOS and Windows smoke runs after merging while retaining the full cross-platform pull-request matrix and release artifact smoke validation. No current merge-blocking risk remains. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR reduces redundant post-merge and release validation while retaining an exact-commit release gate.
Confidence Score: 5/5The PR appears safe to merge because every released SHA remains gated by successful main CI, and the release-built package is still smoke-tested. No actionable failure remains: pull requests retain cross-platform coverage, exact main SHAs retain Ubuntu typechecking and tests, and releases retain exact-SHA gating plus packed-artifact validation.
|
| Filename | Overview |
|---|---|
| .github/workflows/ci.yml | Selects the full three-platform matrix for pull requests and an Ubuntu-only matrix for main pushes while preserving all validation steps. |
| .github/workflows/release.yml | Removes redundant source typechecking and tests while retaining exact-SHA CI gating and validation of the versioned packed artifact. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
PR[Pull request] --> Matrix[CI: Ubuntu, macOS, Windows]
Merge[Push to main] --> Ubuntu[CI: Ubuntu]
Ubuntu --> Checks[Typecheck, tests, package smoke test, doctor]
Checks --> Gate{Exact SHA CI succeeded?}
Dispatch[Manual release dispatch on main] --> Gate
Gate -->|Yes| Version[Set release version]
Gate -->|No| Stop[Stop release]
Version --> Package[Build and pack artifact]
Package --> Smoke[Package installation smoke test]
Smoke --> Publish[Publish release]
Reviews (1): Last reviewed commit: "ci: reduce duplicate validation after me..." | Re-trigger Greptile
PR CI currently runs the full Linux/macOS/Windows matrix again after merge, and the release workflow repeats typechecking and tests once more. That adds cost without materially increasing confidence for the normal PR path.
PRs now keep the full three-OS matrix, while pushes to
mainrun the same smoke job only on Ubuntu so direct pushes and the exact-SHA release gate still have a safety net. Releases continue to verify the versioned packed artifact, but no longer rerun typechecking and tests that already passed on the exactmaincommit.Summary by CodeRabbit