Repository navigation
feat: return per-item batch results, migrate tests, update_contract_i… - #834
Merged
misrasamuelisiguzor-oss merged 2 commits intoOct 19, 2026
Merged
misrasamuelisiguzor-oss merged 2 commits into
misrasamuelisiguzor-oss merged 2 commits into
Conversation
…ds (WHEELBACK#776 WHEELBACK#763 WHEELBACK#764 WHEELBACK#771) - WHEELBACK#776: execute_with_compliance_batch now returns Vec<SettlementBatchResult> with a per-item status code for every requested settlement ID, so callers can tell which settlements executed and which were skipped (and why). - WHEELBACK#763: Test migrate from schema v1 to v2 with populated state, asserting all queries (is_allowed, is_blocked, address_status) return the same answers. - WHEELBACK#764: Test migrate at CURRENT_SCHEMA_VERSION is a clean no-op (returns current version, emits no schema_migrated event, leaves storage untouched). - WHEELBACK#771: Add admin-only update_contract_ids entrypoint to settlement-workflow to re-point at upgraded compliance/treasury contracts, emits contract_ids_updated.
|
@Promazin Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
execute_with_compliance_batch#776 —execute_with_compliance_batchnow returnsVec<SettlementBatchResult>(one per-item status per requested ID, in order):Executed,SkippedNotFound,SkippedAlreadyExecuted,SkippedOnHold,SkippedThresholdNotMet,SkippedExecutionDeadlineExceeded,SkippedInvalidTokenContract,SkippedTokenNotAllowed. Addedtreasury_error_to_batch_resultmapping. Updated all call sites/tests.migratefrom schema v1 to v2 with populated state #763 —migrate_v1_to_v2_preserves_populated_stateandmigrate_preserves_address_status_for_blocked_and_expiring: seed v1-shaped storage with allowed/blocked/expiring addresses, runmigrate, assert every query returns the same answers.migratewhen already at current schema version #764 —migrate_at_current_version_is_noop: callingmigrateatCURRENT_SCHEMA_VERSIONreturns the current version, emits noschema_migratedevent, leaves storage untouched.update_contract_idsadmin entrypoint to settlement-workflow #771 — Added admin-onlyupdate_contract_idsentrypoint (re-pinsComplianceId/TreasuryId), emitscontract_ids_updated, rejected while paused. Added tests and updated ABI snapshot.Closes #776
Closes #763
Closes #764
Closes #771