Repository navigation
feat: consolidate errors, add operators to sweep_expired, add snapsho… - #833
Merged
misrasamuelisiguzor-oss merged 2 commits intoOct 19, 2026
Conversation
…t filter - WHEELBACK#770: Replace TreasuryError with WorkflowError across settlement-workflow admin paths (initialize, transfer_admin, accept_admin, pause, unpause, get_admin, execute_with_compliance, execute_with_compliance_batch). Add WorkflowError variants AlreadyInitialized, ContractPaused, NoPendingAdmin. - WHEELBACK#761: Add optional state filter to export_snapshot_page in compliance for allowed-only or blocked-only pages. - WHEELBACK#766: Consolidate ContractError and ComplianceError into ComplianceError in compliance-errors crate; compliance contract re-exports it. - WHEELBACK#762: Allow operators (not just admin) to call sweep_expired.
|
@Pythagoras-x Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#770 — settlement-workflow/src/lib.rs: Replaced all
TreasuryErrorreturns/panics withWorkflowErroracrossinitialize,transfer_admin,accept_admin,pause,unpause,get_admin,execute_with_compliance,execute_with_compliance_batch,require_admin, andrequire_not_paused. AddedWorkflowErrorvariantsAlreadyInitialized = 11,ContractPaused = 12,NoPendingAdmin = 13.#761 — compliance/src/lib.rs: Added optional
state: Option<AddressState>parameter toexport_snapshot_pagefor allowed-only or blocked-only filtering.#766 — crates/compliance-errors/src/lib.rs: Merged all
ContractErrorvariants intoComplianceError(discriminants 1-11 preserved). compliance/src/lib.rs now imports and re-exportsComplianceError; removed the localContractErrorenum. Updated all test files and protocol-errors/ references accordingly.#762 — compliance/src/lib.rs: Changed
sweep_expiredto userequire_admin_or_operatorinstead ofrequire_admin, allowing operators to run expiry sweeps.Closes #770
Closes #761
Closes #766
Closes #762