Repository navigation
fix(clippy): collapse match-arm guards to keep CI green on newer stable - #458
Merged
Merged
Conversation
`cargo clippy -- -D warnings` fails on Rust 1.95 with three
`collapsible_match` errors that older stable did not emit:
crates/checks/src/commitment_not_cleared.rs:70
crates/checks/src/commitment_not_cleared.rs:78
crates/checks/src/supply_cap.rs:74
CI pins `dtolnay/rust-toolchain@stable`, so this becomes a build failure
for every contributor the moment the runner picks up a newer toolchain —
a red main that nobody caused.
Moves the inner `if` conditions into match-arm guards. Behaviour is
unchanged: when a guard fails the arm falls through to `_ => {}`, which
is exactly what the inner `if` did.
Verified on 1.95: fmt clean, clippy clean with -D warnings, 1041 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo clippy --all-targets -- -D warningsfails on Rust 1.95 with threecollapsible_matcherrors that older stable did not emit:crates/checks/src/commitment_not_cleared.rs:70crates/checks/src/commitment_not_cleared.rs:78crates/checks/src/supply_cap.rs:74CI pins
dtolnay/rust-toolchain@stable, so this turns into a redmainfor every contributor the moment the runner picks up a newer toolchain — a failure nobody introduced and which is confusing to debug.Change
Moves the inner
ifconditions into match-arm guards.Behaviour is unchanged: when a guard fails, the arm falls through to
_ => {}, which is exactly what the innerifalready did.Verification (local, Rust 1.95.0)
cargo fmt --all -- --check— cleancargo clippy --all-targets -- -D warnings— cleancargo test --workspace— 1041 passed, 0 failed