Repository navigation
fix(web): portfolio collect-fees shows authenticate prompt instead of redirecting - #1284
Merged
Mimah97 merged 1 commit intoOct 18, 2026
Conversation
… token is missing Closes Vatix-Protocol#1246
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1246
Summary
Replaced the silent redirect in
handleCollectFeeswith a state-driven authenticate prompt that reuses the existinghandleAuthenticateflow.Changes to
apps/web/app/portfolio/page.tsx:pendingCollectPositionIdstate to track which position triggered the collect action before authentication.doCollectFeescallback so bothhandleCollectFeesandhandleAuthenticatecan invoke it without circular dependencies.handleCollectFees: Instead ofrouter.replace('/')when!authToken, it setspendingCollectPositionIdand returns, keeping the user on the page.handleAuthenticate: After a successful authentication, it checks for a pending collect and callsdoCollectFeesto proceed automatically.pendingCollectPositionIdis set. The general authenticate CTA is hidden while the collect-specific one is visible.Changes to
apps/web/__tests__/PortfolioPage.test.tsx:configurableso tests can override it./.Opened with PRmaster after human review.