Repository navigation
test(api): cover SearchService limit/offset clamp bounds (#1252) - #1280
Open
Adithya9605 wants to merge 1 commit into
Open
Adithya9605 wants to merge 1 commit into
Adithya9605 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds table-driven tests for the limit clamp (50, 51, Infinity, 1, 0, negative, NaN, fractional) and offset clamp (negative, NaN, fractional, large). Tests only; no production code changed.
Related issue
Type of change
Contract drift check
How was this tested?
Ran
search.service.spec.tsin an isolated ts-jest sandbox: the 12 new cases pass. Two existing tests (ranks pools by volume descending...andguards the volume24h cast...) fail on unmodifiedmainin that sandbox too, so they are not caused by this change.Checklist