Repository navigation
fix(api): reject non-hex webhook signatures (#1253) - #1279
Open
Adithya9605 wants to merge 1 commit into
Open
Adithya9605 wants to merge 1 commit into
Adithya9605 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyWebhookSignaturedecoded the signature withBuffer.from(sig, 'hex'), which stops at the first invalid character. A valid digest followed by junk (e.g.<digest>zz) decoded to the same 32 bytes and passed. The signature is now checked against/^[0-9a-fA-F]{64}$/before decoding. Addswebhook.types.spec.tscovering the cases in the issue.Related issue
Type of change
Contract drift check
How was this tested?
Ran the new spec in an isolated ts-jest sandbox: 6 passed.
<digest>zzis accepted by the old code and rejected now. A correct digest and a wrong well-formed digest behave as before.Checklist