Skip to content

update:worldedit的i18n准备 - #1188

Open
THEXN wants to merge 1 commit into
UnrealMultiple:masterfrom
THEXN:master
Open

update:worldedit的i18n准备#1188
THEXN wants to merge 1 commit into
UnrealMultiple:masterfrom
THEXN:master

Conversation

@THEXN

@THEXN THEXN commented Aug 8, 2026

Copy link
Copy Markdown
Member

更新插件/修复BUG

  • 插件已修改版本号
  • 更新插件README.md中的更新日志
  • 插件可以正常工作

Summary by Sourcery

通过将面向用户的字符串接入本地化助手并更新元数据,为 WorldEdit 插件添加 i18n(国际化)准备。

增强内容:

  • 将 WorldEdit 命令消息、日志、错误以及配置 I/O 字符串通过 GetString 本地化助手进行路由,以便为国际化做好准备。
  • 本地化并重写 Config 类的 XML 文档和控制台消息,使其更适合中文描述。
  • 调整 WorldEdit 命令结果消息,以使用本地化模板,同时保持现有行为不变。

文档:

  • 在 README 的更新日志中新增 v2026.08.08 条目,记录本次 i18n 准备工作。
Original summary in English

Summary by Sourcery

Add i18n readiness to WorldEdit plugin by routing user-facing strings through a localization helper and updating metadata.

Enhancements:

  • Route WorldEdit command messages, logs, errors, and config I/O strings through a GetString localization helper to prepare for internationalization.
  • Localize and rewrite Config class XML documentation and console messages into Chinese-friendly descriptions.
  • Adjust WorldEdit command result messages to use localized templates while preserving existing behavior.

Documentation:

  • Update README changelog with a new v2026.08.08 entry documenting the i18n preparation work.

@THEXN
THEXN requested a review from a team as a code owner August 8, 2026 09:54

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我给出了几点总体反馈:

  • 你现在在像 ConfigParser 这样的非命令类中调用 GetString;请确保本地化辅助工具在这些静态/底层环境中是可访问且安全可用的(例如通过共享的静态类或正确的 using 引入),以保证这些文件仍然可以正常编译,并且不会引入意料之外的依赖。
给 AI Agent 的提示
请根据这次代码审查中的评论进行修改:

## 总体评论
- 你现在在像 `Config``Parser` 这样的非命令类中调用 `GetString`;请确保本地化辅助工具在这些静态/底层环境中是可访问且安全可用的(例如通过共享的静态类或正确的 using 引入),以保证这些文件仍然可以正常编译,并且不会引入意料之外的依赖。

Sourcery 对开源项目是免费的——如果你觉得我们的代码审查有帮助,请考虑分享 ✨
帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈改进后续的代码审查。
Original comment in English

Hey - I've left some high level feedback:

  • You now call GetString from non-command classes like Config and Parser; ensure the localization helper is accessible and safe to use in these static/low-level contexts (e.g., via a shared static class or proper using), so these files still compile and don’t introduce unexpected dependencies.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- You now call `GetString` from non-command classes like `Config` and `Parser`; ensure the localization helper is accessible and safe to use in these static/low-level contexts (e.g., via a shared static class or proper using), so these files still compile and don’t introduce unexpected dependencies.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant