update:worldedit的i18n准备 - #1188
Open
THEXN wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Hey - 我给出了几点总体反馈:
- 你现在在像
Config和Parser这样的非命令类中调用GetString;请确保本地化辅助工具在这些静态/底层环境中是可访问且安全可用的(例如通过共享的静态类或正确的 using 引入),以保证这些文件仍然可以正常编译,并且不会引入意料之外的依赖。
给 AI Agent 的提示
请根据这次代码审查中的评论进行修改:
## 总体评论
- 你现在在像 `Config` 和 `Parser` 这样的非命令类中调用 `GetString`;请确保本地化辅助工具在这些静态/底层环境中是可访问且安全可用的(例如通过共享的静态类或正确的 using 引入),以保证这些文件仍然可以正常编译,并且不会引入意料之外的依赖。帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈改进后续的代码审查。
Original comment in English
Hey - I've left some high level feedback:
- You now call
GetStringfrom non-command classes likeConfigandParser; ensure the localization helper is accessible and safe to use in these static/low-level contexts (e.g., via a shared static class or proper using), so these files still compile and don’t introduce unexpected dependencies.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You now call `GetString` from non-command classes like `Config` and `Parser`; ensure the localization helper is accessible and safe to use in these static/low-level contexts (e.g., via a shared static class or proper using), so these files still compile and don’t introduce unexpected dependencies.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
更新插件/修复BUG
Summary by Sourcery
通过将面向用户的字符串接入本地化助手并更新元数据,为 WorldEdit 插件添加 i18n(国际化)准备。
增强内容:
GetString本地化助手进行路由,以便为国际化做好准备。文档:
Original summary in English
Summary by Sourcery
Add i18n readiness to WorldEdit plugin by routing user-facing strings through a localization helper and updating metadata.
Enhancements:
Documentation: