multiple course group managers - #765
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the unity-course worker script to support assigning multiple PI group managers when creating a new course user and its PI group.
Changes:
- Accepts a comma-separated list of manager UIDs instead of a single UID.
- Creates/validates multiple manager
UnityUserobjects and attempts to add each to the PI group as a manager.
Suppressed comments (1)
workers/unity-course.php:71
- This block uses invalid PHP
for (... in ...)syntax, and it also references$manager(undefined after switching to$managers) and$manager_uid(not defined in this loop) when setting mail / adding managers. Select a primary manager for the single-valuedmailattribute and iterate managers withforeach ($managers as $manager_uid => $manager)when adding managers.
for ($managers as $manager) {
$course_pi_group->newUserRequest($manager, false);
$course_pi_group->approveUser($manager);
$course_pi_group->addManagerUID($manager_uid);
}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
simonLeary42
force-pushed
the
simonLeary42-patch-1
branch
from
August 21, 2026 15:17
4dba3eb to
c5e9828
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.