ENH: Add station pressure to altimeter and sea-level pressure conversions#4096
Open
manduinca wants to merge 2 commits into
Open
ENH: Add station pressure to altimeter and sea-level pressure conversions#4096manduinca wants to merge 2 commits into
manduinca wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Adds the two forward conversions requested in #3369, since MetPy already had the inverses:
station_pressure_to_altimeter(pressure, height)— the analytic inverse ofaltimeter_to_station_pressure.station_pressure_to_sea_level_pressure(pressure, height, temperature)— reduces a measured station pressure to sea level (Wallace & Hobbs eq. 2.29/2.31).I derived both by inverting the existing functions rather than the NWS PDF mentioned in the issue, so the constants and references match what MetPy already uses (
altimeter_to_station_pressure, Smithsonian Handbook 1951). Both use the standard@exporter.export/@preprocess_and_wrap/@check_unitsdecorators and are registered in the API docs.Tests cover reference values (inHg and hPa/masked arrays) plus round-trip checks against the existing inverse functions.
Checklist