fix: only transmit 0x040 SAIL_WIND on MWV sentences, not XDR#51
Open
georgesleen wants to merge 1 commit into
Open
fix: only transmit 0x040 SAIL_WIND on MWV sentences, not XDR#51georgesleen wants to merge 1 commit into
georgesleen wants to merge 1 commit into
Conversation
The CV7 sends MWV (wind angle/speed) and XDR (temperature) back-to-back each cycle. The scheduler was calling WIND_SENSOR__CAN_transmit for both, causing 0x040 to be sent twice per cycle — the XDR-triggered transmission sent stale wind data since XDR only updates temp, which isn't in 0x040.
Contributor
Author
|
Closes #52 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WIND_SENSOR__CAN_transmitfor both sentence types, causing0x040to be sent twice per cycleself->temp— a field not present in0x040per the CAN frame specCAN_transmitcall so it only fires when the parsed sentence wasMESSAGE_MWV