Conversation
This reverts commit 7d6c3f7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the work to remove
lernawe regressed the performance oftestruns from the root because we lost the caching that lerna was providing.turborepois an alternate tool that could replace that functionality.Similar to the lerna implementation, builds with turbo would run
tscin each package individually causing duplicate work. The benefit you get from this extra work is that the caching is handled quite well (assuming there are no issues with the task definitions in turbo.json). Subsequent builds that hit the cache are very very fast (<1s), and the task selection seems quite effective.The downside of turbo is that without using project references (per the turbo docs), a change in @turf/helpers invalidates nearly the entire repo and so all of these builds must be done again from scratch and are quite expensive.
If someone knows how to use turbo and project references together, or knows how to get similar performance from turbo without project references, I value the time spent typechecking more than the potential time saved running tests across the entire repo.
I'm interested in the following metrics: