vulkan(replay): don't hard-fail on optional device features the replay GPU lacks - #4
Draft
manon-traverse wants to merge 1 commit into
Draft
vulkan(replay): don't hard-fail on optional device features the replay GPU lacks#4manon-traverse wants to merge 1 commit into
manon-traverse wants to merge 1 commit into
Conversation
…y GPU lacks When replaying a capture on a slightly different driver than it was made on (e.g. an Android updatable/prerelease driver at capture time vs the system driver at replay), the replay physical device may not advertise an optional feature the capture had enabled, and replay aborted with APIHardwareUnsupported. Strip the unsupported feature from the replay device creation and warn instead, so the frame can still be replayed - it usually does not exercise the stripped feature. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Don't hard-fail replay when the replay GPU lacks an optional physical-device feature the capture enabled.
Problem
Serialise_vkCreateDevicechecks eachVkPhysicalDeviceFeaturesbit the capture enabled against the replay device and aborts withAPIHardwareUnsupportedif one is missing. When a capture is made on a slightly different driver than replay (e.g. an Android updatable/prerelease Adreno driver at capture vs the system driver at replay), the replay device may not advertise an optional feature (observed:sparseResidencyImage3D), so replay fails outright.Fix
If the replay device lacks an enabled optional feature, strip it from the replay
vkCreateDeviceandRDCWARNinstead of failing. The frame usually does not exercise the stripped feature, so replay proceeds.Testing
A capture that previously failed replay with "Capture requires physical device feature 'sparseResidencyImage3D' which is not supported" now opens and replays.
🤖 Draft opened on the Traverse-Research fork for internal human review before any upstream submission.