vulkan(android): return a no-op vkFrameBoundaryANDROID instead of NULL - #2
Draft
manon-traverse wants to merge 1 commit into
Draft
vulkan(android): return a no-op vkFrameBoundaryANDROID instead of NULL#2manon-traverse wants to merge 1 commit into
manon-traverse wants to merge 1 commit into
Conversation
RenderDoc does not implement VK_ANDROID_frame_boundary, so GetDeviceProcAddr returned NULL for vkFrameBoundaryANDROID. Apps that enable the extension and call the function unconditionally (e.g. some Adreno titles) then dereference a null pointer and crash while capturing. Return a no-op stub so the call is safe; RenderDoc already delimits frames via vkQueuePresentKHR. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a null-pointer crash when capturing Android apps that use
VK_ANDROID_frame_boundary.Problem
RenderDoc does not implement
VK_ANDROID_frame_boundary, sovkGetDeviceProcAddr(device, "vkFrameBoundaryANDROID")returnsNULL. Apps that enable the extension and callvkFrameBoundaryANDROIDunconditionally (observed on Adreno titles, e.g. Asphalt 9) then call through a null pointer and crash (SIGSEGV) as soon as the capture layer is active.Fix
Return a small no-op stub for
vkFrameBoundaryANDROIDfrom the layer'sGetDeviceProcAddrso the call is safe. RenderDoc already delimits frames viavkQueuePresentKHR, so nothing else is needed for single-frame capture. (Mirrors how gfxreconstruct provides a valid no-op for this function.)Testing
With this stub the target app runs normally under the capture layer and a frame captures successfully; without it the app crashes at instance/device init.
🤖 Draft opened on the Traverse-Research fork for internal human review before any upstream submission.