build(android): give the host include-bin helper a .exe suffix on Windows hosts - #1
Draft
manon-traverse wants to merge 1 commit into
Draft
build(android): give the host include-bin helper a .exe suffix on Windows hosts#1manon-traverse wants to merge 1 commit into
manon-traverse wants to merge 1 commit into
Conversation
…dows When cross-compiling for Android the top-level CMake takes the UNIX path (the target, Android, is Unix) and builds the include-bin resource helper for the *host* via HOST_NATIVE_CPP_COMPILER. On a Windows host the output was named "include-bin" with no extension, which cmd.exe refuses to execute, breaking the build. Add a .exe suffix when CMAKE_HOST_WIN32 so the helper is runnable. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When cross-compiling RenderDoc for Android from a Windows host, the build fails while generating the embedded resources.
Problem
The top-level
renderdoc/CMakeLists.txttakes theif(UNIX)path when building for Android (the target, Android, is Unix). In the cross-compiling branch it builds theinclude-binresource helper for the host viaHOST_NATIVE_CPP_COMPILER, writing the output asinclude-binwith no extension. On a Windows hostcmd.exerefuses to execute an extension-less file, so the build stops with'…\include-bin' is not recognized as an internal or external command.Fix
Append a
.exesuffix to the host helper's output name (and the references to it) whenCMAKE_HOST_WIN32. No change on Linux/macOS hosts.Testing
Built the Android arm64 capture layer +
renderdoccmdfrom a Windows host (NDK r28c, Ninja) — the helper now builds and runs, and the full layer/renderdoccmdlink succeeds.🤖 Draft opened on the Traverse-Research fork for internal human review before any upstream submission.