Skip to content

refactor(core): move AckStream, DropStream, ResponseHandlers and ChanStream into core behind remote-adapter feature #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LiamCarPer wants to merge 7 commits into
base: main
Choose a base branch
from
Open

refactor(core): move AckStream, DropStream, ResponseHandlers and ChanStream into core behind remote-adapter feature #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2a6cab3
refactor(core): move AckStream, DropStream, ResponseHandlers and Chan…
LiamCarPer Jul 11, 2026
520e7ab
fix: add module docs and AckDecoder type alias to silence clippy warn…
LiamCarPer Jul 11, 2026
26cd198
fix: run cargo fmt and fix postgres tokio_postgres ChanStream import
LiamCarPer Jul 12, 2026
83adf15
fix: add docs for ResponsePayload and extract TestAckStream type alias
LiamCarPer Jul 12, 2026
0e098be
Update crates/socketioxide-core/src/adapter/mod.rs
LiamCarPer Jul 12, 2026
48fa11b
fix: add default-features=false, move module docs into stream.rs, add…
LiamCarPer Jul 12, 2026
faa54f1
fix: use std::io::Error::other instead of Error::new
LiamCarPer Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion crates/socketioxide-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,32 @@ license.workspace = true
readme.workspace = true

[features]
remote-adapter = []
remote-adapter = [
"dep:pin-project-lite",
"dep:futures-util",
"dep:tokio",
"dep:tracing",
]

[dependencies]
bytes.workspace = true
engineioxide-core = { version = "0.2", path = "../engineioxide-core" }
serde.workspace = true
thiserror.workspace = true
futures-core.workspace = true
futures-util = { workspace = true, optional = true }

@Totodore Totodore Jul 12, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add default-features = false + only pick the features needed. Same goes for the other added deps if they have features.

pin-project-lite = { workspace = true, optional = true }
smallvec = { workspace = true, features = ["serde"] }
tokio = { workspace = true, features = ["sync", "time"], optional = true }
tracing = { workspace = true, optional = true }

[target."cfg(fuzzing)".dependencies]
arbitrary = { version = "1.4.2", features = ["derive"] }

[dev-dependencies]
serde_json.workspace = true
rmp-serde.workspace = true
tokio = { workspace = true, features = ["macros", "rt"] }

[lints]
workspace = true
2 changes: 2 additions & 0 deletions crates/socketioxide-core/src/adapter/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ use errors::{AdapterError, BroadcastError, SocketError};
pub mod errors;
#[cfg(feature = "remote-adapter")]
pub mod remote_packet;
#[cfg(feature = "remote-adapter")]
pub mod stream;
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed

/// A room identifier
pub type Room = Cow<'static, str>;
Expand Down
Loading