fix: pass maxBuffer to the pnpm licenses list call#750
Open
joshuaisaact wants to merge 1 commit into
Open
Conversation
getPnpmProjectDependencies runs `pnpm licenses list --json --prod` through promisified exec with no maxBuffer, so it falls back to Node's 1MB default. On a large monorepo the JSON output exceeds that and the call dies with ERR_CHILD_PROCESS_STDIO_MAXBUFFER before any licenses are resolved. Set an explicit maxBuffer so large outputs are read in full.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #749.
getPnpmProjectDependenciescallspnpm licenses list --json --prodvia the promisifiedexecwithout amaxBuffer, so it uses Node's 1MB default. On a large pnpm monorepo the output is bigger than that and the run throws ERR_CHILD_PROCESS_STDIO_MAXBUFFER before resolving anything. The npm resolver doesn't go through exec so it's unaffected.This sets an explicit maxBuffer on that call. I picked 256MB as a value that won't realistically be hit; happy to change the number, or switch the call to execFile/streaming instead, if you'd rather handle it differently.